Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove support for v0 format #2496

Merged
merged 7 commits into from
Nov 24, 2024
Merged

chore: Remove support for v0 format #2496

merged 7 commits into from
Nov 24, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

This PR is removing the v0 format support from GO Feature Flag.

Warning

This PR should be merged when releasing a version that remove support for v0 format.
We should wait at least until v1.40.0 before releasing it.

Closes issue(s)

Resolve #2403 #2398

Checklist

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit c60b001
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6707e659381b320008da350e

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit bb99ed3
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/67430f183787230008a6a5fa

@thomaspoignant thomaspoignant added the on-hold If you're PR is ready but needs to wait a bit before merging it label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (78f58dd) to head (bb99ed3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/editor/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   84.78%   84.84%   +0.05%     
==========================================
  Files         111      111              
  Lines        5180     5167      -13     
==========================================
- Hits         4392     4384       -8     
+ Misses        624      620       -4     
+ Partials      164      163       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added the Stale When an issue is open for too long label Oct 25, 2024
@github-actions github-actions bot removed the Stale When an issue is open for too long label Oct 25, 2024
@thomaspoignant thomaspoignant merged commit db4bc70 into main Nov 24, 2024
22 checks passed
@thomaspoignant thomaspoignant deleted the feat-2398 branch November 24, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold If you're PR is ready but needs to wait a bit before merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DTO layer to support v1 flag format only
1 participant