Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor bucketing key to be a pointer as all other elements from DTO #2395

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

refactor bucketing key to be a pointer as all other elements from DTO

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 3439c76
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66edc24ccbbc860008db3857
😎 Deploy Preview https://deploy-preview-2395--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…rom DTO

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.08%. Comparing base (4cbeda2) to head (3439c76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/flag/internal_flag.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
- Coverage   86.11%   86.08%   -0.03%     
==========================================
  Files         102      102              
  Lines        3780     3787       +7     
==========================================
+ Hits         3255     3260       +5     
- Misses        400      401       +1     
- Partials      125      126       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit 239c66c into main Sep 20, 2024
20 of 22 checks passed
@thomaspoignant thomaspoignant deleted the fix-bucketingkey-ref branch September 20, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant