Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python-provider): hook error #2365

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

tungntpham
Copy link
Contributor

@tungntpham tungntpham commented Sep 16, 2024

Remove the use of details. It looks like this has been a copy and paste error.

In the case of evaluation error, regardless of whether the flag has been cached, we should still want to collect an error event

Description

  • What was the problem?
    • The error method of DataCollectorHook use a non declared variable details. This seems to be a copy and paste of the after method.
  • How it is resolved?
    • Remove the use of details in the method
  • How can we test the change?
    • Added an unit test
  • If there are breaking changes, please describe them in detail and why we cannot avoid them.
    • Not a breaking change

Closes issue(s)

Resolve #2366

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Remove the use of `details`. It looks like this has been a copy and paste error.

In the case of evaluation error, regardless of whether the flag has been cached, we should still want to collect an error event
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 23268dc
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66e942b8061f88000875c0e9

@thomaspoignant thomaspoignant changed the title Fix hook error fix(python-provider): hook error Sep 17, 2024
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (d477e16) to head (23268dc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2365   +/-   ##
=======================================
  Coverage   86.07%   86.07%           
=======================================
  Files         102      102           
  Lines        3771     3771           
=======================================
  Hits         3246     3246           
  Misses        400      400           
  Partials      125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is indeed a copy/paste error.
I will release a fix version for the python provider and it will be part of it.

@thomaspoignant thomaspoignant merged commit d3bcf52 into thomaspoignant:main Sep 17, 2024
22 checks passed
@thomaspoignant
Copy link
Owner

@tungntpham A version 0.2.1 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) <error method of DataCollectorHook class in python-provider use a non declared variable details>
2 participants