-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python-provider): hook error #2365
fix(python-provider): hook error #2365
Conversation
Remove the use of `details`. It looks like this has been a copy and paste error. In the case of evaluation error, regardless of whether the flag has been cached, we should still want to collect an error event
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 102 102
Lines 3771 3771
=======================================
Hits 3246 3246
Misses 400 400
Partials 125 125 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this is indeed a copy/paste error.
I will release a fix version for the python provider and it will be part of it.
@tungntpham A version |
Remove the use of
details
. It looks like this has been a copy and paste error.In the case of evaluation error, regardless of whether the flag has been cached, we should still want to collect an error event
Description
error
method ofDataCollectorHook
use a non declared variabledetails
. This seems to be a copy and paste of theafter
method.details
in the methodCloses issue(s)
Resolve #2366
Checklist
README.md
and/website/docs
)