Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OFREP): Add cacheable metadata #2163

Merged
merged 3 commits into from
Jul 30, 2024
Merged

feat(OFREP): Add cacheable metadata #2163

merged 3 commits into from
Jul 30, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

Add cacheable metadata in OFREP API response.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 6555bbb
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66a908271cd10b0008b2d387

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the add-metadata-cacheable branch from a2f6f56 to 52a702a Compare July 30, 2024 15:34
Copy link

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (f797c69) to head (6555bbb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2163      +/-   ##
==========================================
+ Coverage   86.08%   86.10%   +0.01%     
==========================================
  Files          99       99              
  Lines        3694     3699       +5     
==========================================
+ Hits         3180     3185       +5     
  Misses        394      394              
  Partials      120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit 6627a64 into main Jul 30, 2024
22 checks passed
@kodiakhq kodiakhq bot deleted the add-metadata-cacheable branch July 30, 2024 15:39
thomaspoignant added a commit that referenced this pull request Sep 5, 2024
* feat(OFREP): Add cacheable metadata

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

* fix test

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

---------

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant