Skip to content

Commit

Permalink
Fix nasa#2175, Rename Reset Counters Event IDs
Browse files Browse the repository at this point in the history
  • Loading branch information
thnkslprpt committed Oct 21, 2022
1 parent a922c47 commit 56c3123
Show file tree
Hide file tree
Showing 15 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion modules/evs/eds/cfe_evs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@
the following telemetry:
- \b \c \EVS_CMDPC - command execution counter will
increment
- The #CFE_EVS_RSTCNT_EID debug event message will be
- The #CFE_EVS_RESET_INF_EID debug event message will be
generated

\par Error Conditions
Expand Down
2 changes: 1 addition & 1 deletion modules/evs/fsw/inc/cfe_evs_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
*
* \link #CFE_EVS_RESET_COUNTERS_CC EVS Reset Counters Command \endlink success.
*/
#define CFE_EVS_RSTCNT_EID 16
#define CFE_EVS_RESET_INF_EID 16

/**
* \brief EVS Set Filter Command Success Event ID
Expand Down
2 changes: 1 addition & 1 deletion modules/evs/fsw/inc/cfe_evs_msg.h
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
** will be reset to 0
** - \b \c \EVS_CMDEC - command error counter
** will be reset to 0
** - The #CFE_EVS_RSTCNT_EID debug event message will be
** - The #CFE_EVS_RESET_INF_EID debug event message will be
** generated
**
** \par Error Conditions
Expand Down
2 changes: 1 addition & 1 deletion modules/evs/fsw/src/cfe_evs_task.c
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ int32 CFE_EVS_ResetCountersCmd(const CFE_EVS_ResetCountersCmd_t *data)
CFE_EVS_Global.EVS_TlmPkt.Payload.MessageTruncCounter = 0;
CFE_EVS_Global.EVS_TlmPkt.Payload.UnregisteredAppCounter = 0;

EVS_SendEvent(CFE_EVS_RSTCNT_EID, CFE_EVS_EventType_DEBUG, "Reset Counters Command Received");
EVS_SendEvent(CFE_EVS_RESET_INF_EID, CFE_EVS_EventType_DEBUG, "Reset Counters Command Received");

/* NOTE: Historically the reset counters command does _NOT_ increment the command counter */

Expand Down
2 changes: 1 addition & 1 deletion modules/evs/ut-coverage/evs_UT.c
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ void Test_WriteApp(void)
UT_InitData();
UT_EVS_DoDispatchCheckEvents(&CmdBuf.cmd, sizeof(CmdBuf.cmd), UT_TPID_CFE_EVS_CMD_RESET_COUNTERS_CC,
&UT_EVS_EventBuf);
UtAssert_UINT32_EQ(UT_EVS_EventBuf.EventID, CFE_EVS_RSTCNT_EID);
UtAssert_UINT32_EQ(UT_EVS_EventBuf.EventID, CFE_EVS_RESET_INF_EID);

/* Test writing application data with a create failure using default
* file name
Expand Down
2 changes: 1 addition & 1 deletion modules/sb/eds/cfe_sb.xml
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@
Successful execution of this command may be verified with the
following telemetry:
- \b \c \SB_CMDPC - command execution counter will increment
- The #CFE_SB_CMD1_RCVD_EID informational event message will be generated
- The #CFE_SB_RESET_INF_EID informational event message will be generated

\par Error Conditions
There are no error conditions for this command. If the Software
Expand Down
2 changes: 1 addition & 1 deletion modules/sb/fsw/inc/cfe_sb_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@
*
* \link #CFE_SB_RESET_COUNTERS_CC SB Reset Counters Command \endlink success.
*/
#define CFE_SB_CMD1_RCVD_EID 29
#define CFE_SB_RESET_INF_EID 29

/**
* \brief SB Send Statistics Command Success Event ID
Expand Down
2 changes: 1 addition & 1 deletion modules/sb/fsw/inc/cfe_sb_msg.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
** - \b \c \SB_CMDPC - command execution counter will
** be reset to 0
** - All other counters listed in description will be reset to 0
** - The #CFE_SB_CMD1_RCVD_EID informational event message will
** - The #CFE_SB_RESET_INF_EID informational event message will
** be generated
**
** \par Error Conditions
Expand Down
2 changes: 1 addition & 1 deletion modules/sb/fsw/src/cfe_sb_task.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ int32 CFE_SB_NoopCmd(const CFE_SB_NoopCmd_t *data)
*-----------------------------------------------------------------*/
int32 CFE_SB_ResetCountersCmd(const CFE_SB_ResetCountersCmd_t *data)
{
CFE_EVS_SendEvent(CFE_SB_CMD1_RCVD_EID, CFE_EVS_EventType_DEBUG, "Reset Counters Cmd Rcvd");
CFE_EVS_SendEvent(CFE_SB_RESET_INF_EID, CFE_EVS_EventType_DEBUG, "Reset Counters Cmd Rcvd");

CFE_SB_ResetCounters();

Expand Down
2 changes: 1 addition & 1 deletion modules/sb/ut-coverage/sb_UT.c
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ void Test_SB_Cmds_RstCtrs(void)

CFE_UtAssert_EVENTCOUNT(1);

CFE_UtAssert_EVENTSENT(CFE_SB_CMD1_RCVD_EID);
CFE_UtAssert_EVENTSENT(CFE_SB_RESET_INF_EID);

UT_CallTaskPipe(CFE_SB_ProcessCmdPipePkt, &ResetCounters.SBBuf.Msg, 0, UT_TPID_CFE_SB_CMD_RESET_COUNTERS_CC);
CFE_UtAssert_EVENTSENT(CFE_SB_LEN_ERR_EID);
Expand Down
2 changes: 1 addition & 1 deletion modules/time/eds/cfe_time.xml
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
Successful execution of this command may be verified with the
following telemetry:
- \b \c \TIME_CMDPC - command execution counter will increment
- The #CFE_TIME_RESET_EID informational event message will be generated
- The #CFE_TIME_RESET_INF_EID informational event message will be generated

\par Error Conditions
There are no error conditions for this command. If the Time
Expand Down
2 changes: 1 addition & 1 deletion modules/time/fsw/inc/cfe_time_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
*
* \link #CFE_TIME_RESET_COUNTERS_CC TIME Reset Counters Command \endlink success.
*/
#define CFE_TIME_RESET_EID 5
#define CFE_TIME_RESET_INF_EID 5

/**
* \brief TIME Request Diagnostics Command Success Event ID
Expand Down
2 changes: 1 addition & 1 deletion modules/time/fsw/inc/cfe_time_msg.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
** following telemetry:
** - \b \c \TIME_CMDPC - command execution counter will reset to 0
** - \b \c \TIME_CMDEC - command error counter will reset to 0
** - The #CFE_TIME_RESET_EID informational event message will be generated
** - The #CFE_TIME_RESET_INF_EID informational event message will be generated
**
** \par Error Conditions
** There are no error conditions for this command. If the Time
Expand Down
2 changes: 1 addition & 1 deletion modules/time/fsw/src/cfe_time_task.c
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ int32 CFE_TIME_ResetCountersCmd(const CFE_TIME_ResetCountersCmd_t *data)
CFE_TIME_Global.InternalCount = 0;
CFE_TIME_Global.ExternalCount = 0;

CFE_EVS_SendEvent(CFE_TIME_RESET_EID, CFE_EVS_EventType_DEBUG, "Reset Counters command");
CFE_EVS_SendEvent(CFE_TIME_RESET_INF_EID, CFE_EVS_EventType_DEBUG, "Reset Counters command");

return CFE_SUCCESS;
}
Expand Down
2 changes: 1 addition & 1 deletion modules/time/ut-coverage/time_UT.c
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,7 @@ void Test_PipeCmds(void)
CFE_TIME_Global.LocalTaskCounter = 1;
memset(&CmdBuf, 0, sizeof(CmdBuf));
UT_CallTaskPipe(CFE_TIME_TaskPipe, &CmdBuf.message, sizeof(CmdBuf.cmd), UT_TPID_CFE_TIME_CMD_RESET_COUNTERS_CC);
CFE_UtAssert_EVENTSENT(CFE_TIME_RESET_EID);
CFE_UtAssert_EVENTSENT(CFE_TIME_RESET_INF_EID);

/* Confirm error counters get reset to help cover requirements that are difficult operationally */
UtAssert_ZERO(CFE_TIME_Global.ToneMatchCounter);
Expand Down

0 comments on commit 56c3123

Please sign in to comment.