Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with angular-inviewport v4.0.0 #28

Closed
neilime opened this issue Oct 9, 2018 · 2 comments
Closed

Bug with angular-inviewport v4.0.0 #28

neilime opened this issue Oct 9, 2018 · 2 comments

Comments

@neilime
Copy link

neilime commented Oct 9, 2018

Hi,

I have an error after updating your package thisissoon/angular-inviewport to v4.0.0 :

ERROR in node_modules/@thisissoon/angular-scroll-collapse/app/scroll-collapse/scroll-collapse.directive.d.ts(2,10): error TS2305: Module '".../node_modules/@thisissoon/angular-inviewport/thisissoon-angular-inviewport"' has no exported member 'WindowRef'.

Is it possible to fix it ?

Thank you

@edoparearyee
Copy link

Hi @neilime, thanks for bringing this to our attention. The current version isn't compatible with @thisissoon/angular-inviewport v4.0.0 as it includes a breaking change.

Will update this package in due course to support it but until then you can use v3.x of @thisissoon/angular-inviewport

edoparearyee added a commit that referenced this issue Oct 9, 2018
BREAKING CHANGE: updated @thisissoon/angular-inviewport peer dependency to v4

Fix #28
edoparearyee added a commit that referenced this issue Oct 9, 2018
#29)

BREAKING CHANGE: updated @thisissoon/angular-inviewport peer dependency to v4

Fix #28
@neilime
Copy link
Author

neilime commented Oct 10, 2018

Thank you @edoparearyee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants