Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(window height change): directive doesn't function correctly after viewport height change #22

Closed
jackhkmatthews opened this issue Jun 6, 2018 · 0 comments · Fixed by #30
Closed

bug(window height change): directive doesn't function correctly after viewport height change #22

jackhkmatthews opened this issue Jun 6, 2018 · 0 comments · Fixed by #30
Labels
bug

Comments

@jackhkmatthews
Copy link
Contributor

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Directive appears broken if viewport height is changed after page load.

Expected behavior

Directive should work as normal after viewport height change.

Environment

This repos demo app.
edoparearyee added a commit that referenced this issue Oct 9, 2018
@edoparearyee
fix(ScrollCollapse): recalculate offsetHeight and offsetTop on resize
3f0e3ce 
fixed an issue where if the browser is resized then the minimise and affix states would not be
recalculated correctly

Fix #22
@edoparearyee edoparearyee mentioned this issue Oct 9, 2018
Merged
edoparearyee added a commit that referenced this issue Oct 9, 2018
@edoparearyee
fix(ScrollCollapse): recalculate offsetHeight and offsetTop on resize (…
3661e76 
…#30)

fixed an issue where if the browser is resized then the minimise and affix states would not be
recalculated correctly

Fix #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@edoparearyee @jackhkmatthews