fix: Align Networks/Tokens/lanes Alphabetically #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zelig880
requested changes
Oct 22, 2024
| @@ -29,14 +29,16 @@ const supportedTokens = getAllSupportedTokens({ | |||
|
|
|||
| const tokens = Object.keys(supportedTokens).sort((a, b) => a.localeCompare(b, undefined, { sensitivity: "base" })) | |||
There was a problem hiding this comment.
we were already doing sort here. Why do we have to do below too?! I would keep just once
There was a problem hiding this comment.
another thought.. Should we not actually sort it at the initial methods (so within the "getTokens" and "getNetworks" instead than do it in this individual files?
There was a problem hiding this comment.
Yes the .sort() is not needed here
about your second comment: because getAllSupportedTokens is a function that returns an object and it's not guaranteed to organize an object so I'm doing it here in the top level of the page
Also it's being used in other places all over the app not just CCIP so it will be hard to change this function
| @@ -28,14 +28,16 @@ const supportedTokens = getAllSupportedTokens({ | |||
|
|
|||
| const tokens = Object.keys(supportedTokens).sort((a, b) => a.localeCompare(b, undefined, { sensitivity: "base" })) | |||
Zelig880
approved these changes
Oct 22, 2024
Zelig880
added a commit
that referenced
this pull request
Oct 29, 2024
* get-status API vercel function Co-authored-by: Karim <98668332+khadni@users.noreply.github.com> * fix caching * mock * mock * cleanup * Initial Work on CCIP * feat: Add segments to the navbbar * feat: Tokens' page * Remove code for now * Feat: token page * fix: search * fix: show correct lanes * fix: chainhero search * feat: added total lanes and total networks * fix: show the correct chains for each network * feat: Drawer & filters * First draft to move page out * feat: API integrations * remove unused files * mock * mock * get-status API vercel function Co-authored-by: Karim <98668332+khadni@users.noreply.github.com> * fix caching * cleanup * update * update * update * Move token and Chains * Fix search links * Fix chain after Merge * Fix URL from main navigation * Rename heading * Fix token passing wrong environment * mock * mock * get-status API vercel function Co-authored-by: Karim <98668332+khadni@users.noreply.github.com> * fix caching * cleanup * update * update * update * feat: Drawer Mobile close button * feat: hook tables to seach and filters * feat: lane drawer * remove unused console.logs * Fix Testnet token not working * Add CCIP Directory on sidebar * Include missing import * Fix component import * Fix component import * Fix component import * fix: lane search * Add Search Overlay * fix: breadcrumb * fix: search styles * feat: add search to token * fix: search + tokens operational * fix: lane drawer spacing * feat: copy value component * fix: copy value component * Multiple Changes * mock * mock * get-status API vercel function Co-authored-by: Karim <98668332+khadni@users.noreply.github.com> * fix caching * cleanup * update * update * update * Add Link for the "add my token" button * fix: token drawer * fix: token tabs * feat: fee tokens * Various update from Review * Add RMN * Fix some of the URLs being incorrectly set * Fix build * Fix center align on build * Apply multiple changes from review * Enable RMN and Fix Address URL * Add Native token on feeToken * Add Data typees for Josh * Draft for Network operation * Fix ExplorerUrl * Fix TS issue * Add tooltips * Fix Typo in tooltip * Add Tooltips * fix: Update "list my token"'s url (#15) * fix: Heading colors and other minor css issues (#20) * fix: Page width incorrect (DocsLayout grid) (#19) * mock * mock * get-status API vercel function Co-authored-by: Karim <98668332+khadni@users.noreply.github.com> * fix caching * cleanup * update * update * update * update * Fix: Drawer (#26) * fix: drawer animation * fix: drawer's close button's hover state * fix: Removing the grid banner (#25) * fix: icon sizes & use css variables (#24) * Fix Fee Token URL (#17) * Use Symbol instead than name for Native Gas Token (#16) * Filter out FeeTokenOnly (#18) * Fix: spacing address row (#22) Co-authored-by: Simone Cuomo <simone@thisdot.co> * fix: Header spacing (#23) * fix: Header spacing * fix: gap space in the chain/token hero component * fix: Single/Plural words (#21) * fix: Single/Plural words * fix: lans count * fix: add ? to not trigger a JS error * fix: Align Networks/Tokens/lanes Alphabetically (#27) * fix: Align Networks/Tokens/lanes Alphabetically * fix: remove unused .sort() * fix: remove unused .sort() in Token.astro * Navigation buttons and Backdrop blur * fallback icon * Improve sizing of Chain cards (#28) * Improve Image Fallback (#31) * Fix image fallback on homepage * Improve image fallback handling * Add extra SEO * Fix 340 (#32) * fix: Make the CCIP responsive * fix: CSS responsiveness * fix: typo * fix: minor css issues * fix: use client:load instead of client:only * fix: table padding * fix: token grid * fix: hero paddings * Revert the percentage width --------- Co-authored-by: Simone Cuomo <simone@thisdot.co> * Fix token search * Padding and spaces changes * Feat: Add see more, CSS fixes (#36) * Feat: Add see more, CSS fixes * fix: css padding * fix: chain layout padding * fix: tabs css on iphone se * Review from Nav * Update Tooltio * fix: Breadcrum + page titles (#37) * Update Page to be "directory" instead than "supported-networks" (#29) * Update Page to be "directory" instead than "supported-networks" * Ament links to "directory" * Remove hardcoded URL * update fee token * Update link verbiage for security reason * Improve logic and UI for Operational API * Update API to use Astro URL * fix: lane drawer on main page (#39) * Move statuses to be client side only * Fix lane key * Update capacity to show N/A instead than 0 * Add EnsureOutOfOrder * Add OpenGraph image * Add Get certified on navbar * update links * Remove double Drawer * update links * cleanup * Change default state to status unavailable * Updated changelog links * update * Explorer/Directory Changelog entry * redirect links * rollback * Fix testnet case issue * zksync testnet link * fix package-lock.json * fix changelog * fix links * fix --------- Co-authored-by: Karim <98668332+khadni@users.noreply.github.com> Co-authored-by: Simone Cuomo <simone@thisdot.co> Co-authored-by: Mark Shenouda <mark.s.shenouda@gmail.com> Co-authored-by: Mark S. Shenouda <mark@thisdot.co> Co-authored-by: Mark S. Shenouda <49324987+markshenouda@users.noreply.github.com> Co-authored-by: Crystal Gomes <thedriftofwords@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes #ISSUE_NUMBER_GOES_HERE
...
Description
...
Changes