[SDK] Fix: Undefined chain ID on eip1193 provider input #5871

gregfromstl · 2025-01-02T00:51:06Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on improving the handling of wallet connections in the thirdweb SDK by gracefully managing cases where the chain ID is undefined, particularly for certain wallets.

Detailed summary

Updated the check for chain.id in fromEip1193Provider to ensure it is defined before comparison.
Added a test case to verify connection handling when the chain ID is not provided.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2025-01-02T00:51:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	🛑 Canceled (Inspect)			Jan 4, 2025 0:38am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 4, 2025 0:38am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 4, 2025 0:38am
wallet-ui	🛑 Canceled (Inspect)			Jan 4, 2025 0:38am

linear · 2025-01-02T00:51:09Z

TOOL-2830 Connection Failed Error for Abstract Global Wallet on Upcade Staging

changeset-bot · 2025-01-02T00:51:10Z

🦋 Changeset detected

Latest commit: 9abc3cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Patch
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app · 2025-01-02T00:51:16Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2025-01-02T00:54:29Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45 KB (0%)	900 ms (0%)	3.2 s (+30.71% 🔺)	4.1 s
thirdweb (cjs)	110.81 KB (0%)	2.3 s (0%)	8 s (+28.69% 🔺)	10.2 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	584 ms (+311.95% 🔺)	695 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	285 ms (+160.63% 🔺)	295 ms
thirdweb/react (minimal + tree-shaking)	19.13 KB (0%)	383 ms (0%)	560 ms (-31.5% 🔽)	943 ms

codecov · 2025-01-02T09:00:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (8b1a60d) to head (d57171a).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5871   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5031     5031           
=======================================
+ Hits        32895    32896    +1     
+ Misses      25996    25995    -1     
  Partials      720      720

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 8b1a60d
packages	`52.84% <100.00%> (+<0.01%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/wallets/injected/index.ts	`36.78% <100.00%> (ø)`

... and 1 file with indirect coverage changes

gregfromstl · 2025-01-03T22:35:23Z

Merge activity

Jan 3, 5:35 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jan 3, 5:35 PM EST: A user added this pull request to the Graphite merge queue.
Jan 3, 5:47 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on improving the handling of connections in the `thirdweb` SDK by gracefully managing scenarios where a wallet does not provide a chain ID. It adds checks to avoid errors and includes tests for these cases. ### Detailed summary - Updated `fromEip1193Provider` to check for `undefined` chain ID before switching chains. - Added a test to handle wallet connection with no chain ID. - Ensured compatibility with wallets like Abstract that may not send a chain ID on connection. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing the `thirdweb` SDK by gracefully handling cases where a wallet does not provide a chain ID during connection, ensuring better compatibility with certain wallets. ### Detailed summary - Updated the logic in `fromEip1193Provider` to check for `undefined` chain IDs. - Added a test to verify connection handling when no chain ID is provided. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on improving the handling of wallet connections in the `thirdweb` SDK, specifically addressing cases where the chain ID may be undefined. It ensures that the SDK can gracefully manage connections without a specified chain ID. ### Detailed summary - Modified the check for `chain.id` in `fromEip1193Provider` to allow for undefined chain IDs. - Added a test case to handle wallet connection when no chain ID is provided, ensuring the SDK behaves correctly in this scenario. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing the `thirdweb` SDK by improving the handling of connections to wallets that may not provide a chain ID, ensuring the SDK can gracefully manage these scenarios. ### Detailed summary - Updated `fromEip1193Provider` to check for undefined `chain.id` before switching chains. - Added a test case to handle wallet connections that do not provide a chain ID, ensuring robustness in the connection process. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

gregfromstl requested review from a team as code owners January 2, 2025 00:51

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 2, 2025

github-actions bot assigned gregfromstl Jan 2, 2025

vercel bot deployed to Preview – wallet-ui January 2, 2025 00:53 View deployment

vercel bot deployed to Preview – thirdweb_playground January 2, 2025 00:54 View deployment

vercel bot deployed to Preview – wallet-ui January 2, 2025 00:57 View deployment

vercel bot deployed to Preview – thirdweb_playground January 2, 2025 00:57 View deployment

vercel bot deployed to Preview – docs-v2 January 2, 2025 01:00 View deployment

vercel bot deployed to Preview – thirdweb-www January 2, 2025 01:01 View deployment

joaquim-verges approved these changes Jan 2, 2025

View reviewed changes

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 3, 2025

gregfromstl force-pushed the greg/tool-2830-connection-failed-error-for-abstract-global-wallet-on-upcade branch from d57171a to c118382 Compare January 3, 2025 22:36

gregfromstl force-pushed the greg/tool-2830-connection-failed-error-for-abstract-global-wallet-on-upcade branch from c118382 to 9abc3cc Compare January 3, 2025 22:37

gregfromstl force-pushed the greg/tool-2830-connection-failed-error-for-abstract-global-wallet-on-upcade branch from 9abc3cc to 6976cb4 Compare January 3, 2025 22:39

gregfromstl force-pushed the greg/tool-2830-connection-failed-error-for-abstract-global-wallet-on-upcade branch from 6976cb4 to 79a135a Compare January 3, 2025 22:44

graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 3, 2025

vercel bot deployed to Preview – thirdweb_playground January 3, 2025 23:07 View deployment

vercel bot deployed to Preview – wallet-ui January 3, 2025 23:10 View deployment

vercel bot deployed to Preview – docs-v2 January 3, 2025 23:16 View deployment

vercel bot deployed to Preview – thirdweb-www January 3, 2025 23:16 View deployment

gregfromstl merged commit 1e8ddcb into main Jan 5, 2025
28 of 29 checks passed

gregfromstl deleted the greg/tool-2830-connection-failed-error-for-abstract-global-wallet-on-upcade branch January 5, 2025 07:33

jnsdls mentioned this pull request Jan 4, 2025

Version Packages #5838

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SDK] Fix: Undefined chain ID on eip1193 provider input #5871

[SDK] Fix: Undefined chain ID on eip1193 provider input #5871

gregfromstl commented Jan 2, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 2, 2025 •

edited

Loading

linear bot commented Jan 2, 2025

changeset-bot bot commented Jan 2, 2025 •

edited

Loading

graphite-app bot commented Jan 2, 2025

github-actions bot commented Jan 2, 2025 •

edited

Loading

codecov bot commented Jan 2, 2025

gregfromstl commented Jan 3, 2025 •

edited by graphite-app bot

Loading

[SDK] Fix: Undefined chain ID on eip1193 provider input #5871

[SDK] Fix: Undefined chain ID on eip1193 provider input #5871

Conversation

gregfromstl commented Jan 2, 2025 • edited by pr-codex bot Loading

Problem solved

PR-Codex overview

Detailed summary

vercel bot commented Jan 2, 2025 • edited Loading

linear bot commented Jan 2, 2025

changeset-bot bot commented Jan 2, 2025 • edited Loading

🦋 Changeset detected

graphite-app bot commented Jan 2, 2025

How to use the Graphite Merge Queue

github-actions bot commented Jan 2, 2025 • edited Loading

size-limit report 📦

codecov bot commented Jan 2, 2025

Codecov Report

gregfromstl commented Jan 3, 2025 • edited by graphite-app bot Loading

Merge activity

gregfromstl commented Jan 2, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jan 2, 2025 •

edited

Loading

changeset-bot bot commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

gregfromstl commented Jan 3, 2025 •

edited by graphite-app bot

Loading