[SDK] Feature: Basic EIP7702 Support #5801

gregfromstl · 2024-12-19T01:46:33Z

PR-Codex overview

This PR introduces beta support for EIP-7702 authorization lists, enhancing transaction capabilities and authorization signing within the thirdweb ecosystem.

Detailed summary

Added style configuration in biome.json.
Introduced sleep in smart-wallet-integration.test.ts.
Updated nonce handling to convert to Number in ethers5.ts.
Added types and functions for EIP-7702 in thirdweb.ts and transaction.ts.
Implemented signAuthorization for EIP-7702 in authorization.ts.
Enhanced prepareTransaction to accept authorizationList.
Introduced tests for signAuthorization and prepareTransaction with authorization.
Updated gas estimation to handle authorization lists in estimate-gas.ts.
Added serialization support for EIP-7702 transactions in serialize-transaction.ts.
Created a new wagmiTokenContractConfig in wagmiToken.ts.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-19T01:46:35Z

TOOL-2477 basic 7702 support in TS sdk

changeset-bot · 2024-12-19T01:46:37Z

🦋 Changeset detected

Latest commit: 4413b3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Minor
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-12-19T01:46:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 5:48am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 5:48am
thirdweb-www	❌ Failed (Inspect)			Jan 6, 2025 5:48am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 5:48am

graphite-app · 2024-12-19T01:46:40Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2024-12-19T01:50:07Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.31 KB (+0.49% 🔺)	907 ms (+0.49% 🔺)	429 ms (+29.01% 🔺)	1.4 s
thirdweb (cjs)	111.52 KB (+0.61% 🔺)	2.3 s (+0.61% 🔺)	1.2 s (+7.66% 🔺)	3.4 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	201 ms (+394.38% 🔺)	313 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	47 ms (+405.23% 🔺)	57 ms
thirdweb/react (minimal + tree-shaking)	19.12 KB (0%)	383 ms (0%)	184 ms (+62.91% 🔺)	566 ms

joaquim-verges · 2024-12-19T01:53:51Z

packages/thirdweb/src/transaction/actions/to-serializable-transaction.ts

-      from: options.from ? getAddress(options.from) : undefined,
+      from:
+        typeof options.from === "string" // Is this just an address?
+          ? checksumAddress(options.from)


Getaddress is nice because it throws if invalid input, not sure if checksum does that

joaquim-verges · 2024-12-19T01:54:40Z

packages/thirdweb/src/transaction/actions/eip7702/sign-authorization.ts

+}): Promise<SignedAuthorization[]> {
+  const { authorizations, account } = options;
+
+  return Promise.all(


There's no way to sign multiple authorizations with one signature? Assume this will prompt multiple signatures right

joaquim-verges · 2024-12-19T01:56:09Z

packages/thirdweb/src/transaction/actions/to-serializable-transaction.ts

+      resolvePromisedValue(options.transaction.to),
+      resolvePromisedValue(options.transaction.accessList),
+      resolvePromisedValue(options.transaction.value),
+      resolvePromisedValue(options.transaction.authorizations),


You don't need this right? Weird to have this and the one below

joaquim-verges · 2024-12-19T01:56:45Z

packages/thirdweb/src/transaction/actions/to-serializable-transaction.ts

@@ -112,5 +128,50 @@ export async function toSerializableTransaction(
    accessList,
    value,
    ...feeData,
+    // For some reason authorizationList is not getting properly typed when returned from resolveAndSignAuthorizations?


Prob because of the comment above

joaquim-verges · 2024-12-19T01:57:20Z

packages/thirdweb/src/transaction/actions/to-serializable-transaction.ts

+async function resolveAndSignAuthorizations(
+  options: ToSerializableTransactionOptions,
+): Promise<SignedAuthorization[] | undefined> {
+  if (typeof options.transaction.authorizations === "undefined") {


Don't you need to resolvePromise this first?

codecov · 2024-12-19T02:03:33Z

Codecov Report

Attention: Patch coverage is 88.99083% with 12 lines in your changes missing coverage. Please review.

Project coverage is 53.28%. Comparing base (3683c11) to head (6f4ad21).

Files with missing lines	Patch %	Lines
...transaction/actions/to-serializable-transaction.ts	86.11%	10 Missing ⚠️
packages/thirdweb/src/adapters/ethers5.ts	0.00%	1 Missing ⚠️
.../thirdweb/src/transaction/serialize-transaction.ts	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5801      +/-   ##
==========================================
+ Coverage   53.20%   53.28%   +0.07%     
==========================================
  Files        1101     1102       +1     
  Lines       59095    59174      +79     
  Branches     4816     4837      +21     
==========================================
+ Hits        31444    31528      +84     
+ Misses      26934    26928       -6     
- Partials      717      718       +1

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 3683c11
packages	`50.48% <88.99%> (+0.09%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/gas/estimate-l1-fee.ts	`100.00% <100.00%> (ø)`
.../transaction/actions/eip7702/sign-authorization.ts	`100.00% <100.00%> (ø)`
...irdweb/src/transaction/actions/send-transaction.ts	`46.80% <100.00%> (ø)`
...es/thirdweb/src/transaction/prepare-transaction.ts	`100.00% <ø> (ø)`
packages/thirdweb/src/adapters/ethers5.ts	`53.28% <0.00%> (ø)`
.../thirdweb/src/transaction/serialize-transaction.ts	`88.78% <90.90%> (+1.28%)`	⬆️
...transaction/actions/to-serializable-transaction.ts	`77.98% <86.11%> (+1.79%)`	⬆️

... and 5 files with indirect coverage changes

0xFirekeeper

Beautiful

fix

gregfromstl · 2025-01-01T23:04:30Z

Revive

joaquim-verges · 2025-01-02T09:08:15Z

.changeset/clever-beds-knock.md

+    client: TEST_CLIENT,
+    value: 100n,
+    to: TEST_WALLET_B,
+    authorizationList: authorization,


should be an array right?

joaquim-verges · 2025-01-02T09:09:26Z

packages/thirdweb/src/transaction/actions/send-transaction.ts

+ * const transaction = prepareTransaction({
+ *   chain: sepolia,
+ *   client: client,
+ *   authorizations: [


authorizationList or authorizations? i think it should be the former right?

feat(sdk): basic eip7702 support

ebd61a2

gregfromstl requested review from a team as code owners December 19, 2024 01:46

github-actions bot assigned gregfromstl Dec 19, 2024

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 19, 2024

gregfromstl marked this pull request as draft December 19, 2024 01:47

vercel bot deployed to Preview – wallet-ui December 19, 2024 01:47 View deployment

vercel bot deployed to Preview – thirdweb_playground December 19, 2024 01:48 View deployment

Merge branch 'main' into greg/tool-2477-basic-7702-support-in-ts-sdk

6f4ad21

vercel bot deployed to Preview – wallet-ui December 19, 2024 01:54 View deployment

vercel bot deployed to Preview – thirdweb_playground December 19, 2024 01:54 View deployment

joaquim-verges reviewed Dec 19, 2024

View reviewed changes

vercel bot deployed to Preview – docs-v2 December 19, 2024 02:00 View deployment

vercel bot deployed to Preview – thirdweb-www December 19, 2024 02:06 View deployment

feat(sdk): autofill authorization chainId and nonce

f9addb6

0xFirekeeper approved these changes Dec 19, 2024

View reviewed changes

wip

7c088dd

vercel bot deployed to Preview – wallet-ui December 19, 2024 06:59 View deployment

vercel bot deployed to Preview – thirdweb_playground December 19, 2024 06:59 View deployment

vercel bot deployed to Preview – docs-v2 December 19, 2024 07:04 View deployment

vercel bot deployed to Preview – thirdweb-www December 19, 2024 07:06 View deployment

fix

d59413e

fix

gregfromstl force-pushed the greg/tool-2477-basic-7702-support-in-ts-sdk branch from 55bb597 to d59413e Compare December 19, 2024 07:13

github-actions bot added the Stale label Dec 27, 2024

github-actions bot closed this Dec 29, 2024

gregfromstl reopened this Jan 1, 2025

github-actions bot removed the Stale label Jan 2, 2025

gregfromstl requested a review from joaquim-verges January 2, 2025 08:27

gregfromstl marked this pull request as ready for review January 2, 2025 08:27

vercel bot deployed to Preview – wallet-ui January 2, 2025 08:30 View deployment

vercel bot deployed to Preview – thirdweb_playground January 2, 2025 08:30 View deployment

gregfromstl force-pushed the greg/tool-2477-basic-7702-support-in-ts-sdk branch from bd73f03 to 8d493ca Compare January 2, 2025 08:35

vercel bot deployed to Preview – wallet-ui January 2, 2025 08:38 View deployment

vercel bot deployed to Preview – thirdweb_playground January 2, 2025 08:40 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www January 2, 2025 08:44 Failure

vercel bot deployed to Preview – docs-v2 January 2, 2025 08:45 View deployment

gregfromstl requested a review from 0xFirekeeper January 2, 2025 08:52

gregfromstl force-pushed the greg/tool-2477-basic-7702-support-in-ts-sdk branch from 8d493ca to cf3ad5e Compare January 2, 2025 08:52

vercel bot deployed to Preview – wallet-ui January 2, 2025 08:55 View deployment

vercel bot deployed to Preview – thirdweb_playground January 2, 2025 08:55 View deployment

vercel bot deployed to Preview – docs-v2 January 2, 2025 09:00 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www January 2, 2025 09:00 Failure

joaquim-verges reviewed Jan 2, 2025

View reviewed changes

gregfromstl force-pushed the greg/tool-2477-basic-7702-support-in-ts-sdk branch from cf3ad5e to ae8bee2 Compare January 2, 2025 09:09

joaquim-verges reviewed Jan 2, 2025

View reviewed changes

feat(sdk): simplified EIP-7702 support

4413b3a

gregfromstl force-pushed the greg/tool-2477-basic-7702-support-in-ts-sdk branch from ae8bee2 to 4413b3a Compare January 2, 2025 09:11

gregfromstl requested a review from joaquim-verges January 2, 2025 09:11

vercel bot deployed to Preview – thirdweb_playground January 2, 2025 09:15 View deployment

vercel bot deployed to Preview – wallet-ui January 2, 2025 09:16 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www January 2, 2025 09:19 Failure

vercel bot deployed to Preview – docs-v2 January 2, 2025 09:24 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SDK] Feature: Basic EIP7702 Support #5801

[SDK] Feature: Basic EIP7702 Support #5801

gregfromstl commented Dec 19, 2024 •

edited by pr-codex bot

Loading

linear bot commented Dec 19, 2024

changeset-bot bot commented Dec 19, 2024 •

edited

Loading

vercel bot commented Dec 19, 2024 •

edited

Loading

graphite-app bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 •

edited

Loading

joaquim-verges Dec 19, 2024

joaquim-verges Dec 19, 2024

joaquim-verges Dec 19, 2024

joaquim-verges Dec 19, 2024

joaquim-verges Dec 19, 2024

codecov bot commented Dec 19, 2024 •

edited

Loading

0xFirekeeper left a comment

gregfromstl commented Jan 1, 2025

joaquim-verges Jan 2, 2025

gregfromstl Jan 2, 2025

joaquim-verges Jan 2, 2025

gregfromstl Jan 2, 2025

[SDK] Feature: Basic EIP7702 Support #5801

Are you sure you want to change the base?

[SDK] Feature: Basic EIP7702 Support #5801

Conversation

gregfromstl commented Dec 19, 2024 • edited by pr-codex bot Loading

PR-Codex overview

Detailed summary

linear bot commented Dec 19, 2024

changeset-bot bot commented Dec 19, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Dec 19, 2024 • edited Loading

graphite-app bot commented Dec 19, 2024

How to use the Graphite Merge Queue

github-actions bot commented Dec 19, 2024 • edited Loading

size-limit report 📦

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

0xFirekeeper left a comment

Choose a reason for hiding this comment

gregfromstl commented Jan 1, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregfromstl commented Dec 19, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 19, 2024 •

edited

Loading

vercel bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024 •

edited

Loading

codecov bot commented Dec 19, 2024 •

edited

Loading