Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Feature: UI for crosschain modules #5399

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Conversation

GWSzeto
Copy link
Contributor

@GWSzeto GWSzeto commented Nov 12, 2024

https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview


PR-Codex overview

This PR introduces new features and updates related to cross-chain functionality in the thirdweb package, including new exports, improved contract deployment methods, and enhancements to the dashboard components for better handling of cross-chain contracts.

Detailed summary

  • Added export for getDeployedCloneFactoryContract.
  • Added export for moduleInstalledEvent.
  • Updated TypeScript documentation for next-env.d.ts.
  • Enhanced sidebar links with a "Cross Chain" option.
  • Introduced a new publisher address for TWCloneFactory.
  • Modified keccak256 result handling to use Uint8Array.
  • Implemented nonce handling in installPublishedModule.
  • Added support for cross-chain deployment in deployViaAutoFactory.
  • Created new event types and functions for ProxyDeployedV2.
  • Updated components in the dashboard to support cross-chain contract management.
  • Enhanced error handling and transaction processes in deployment forms.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 06521a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:03am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 17, 2025 0:03am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 17, 2025 0:03am
wallet-ui ⬜️ Skipped (Inspect) Jan 17, 2025 0:03am

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 41.93548% with 36 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (23d8001) to head (fba275c).

Files with missing lines Patch % Lines
.../src/contract/deployment/deploy-via-autofactory.ts 25.80% 23 Missing ⚠️
...rdweb/src/extensions/prebuilts/deploy-published.ts 43.47% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5399      +/-   ##
==========================================
- Coverage   54.85%   54.83%   -0.03%     
==========================================
  Files        1142     1142              
  Lines       60928    60985      +57     
  Branches     5140     5145       +5     
==========================================
+ Hits        33424    33440      +16     
- Misses      26777    26819      +42     
+ Partials      727      726       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from da94509
packages 52.47% <41.93%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...xtensions/modules/common/installPublishedModule.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/utils/ens/namehash.ts 90.00% <100.00%> (+1.76%) ⬆️
...rdweb/src/extensions/prebuilts/deploy-published.ts 80.79% <43.47%> (-3.52%) ⬇️
.../src/contract/deployment/deploy-via-autofactory.ts 58.82% <25.80%> (-13.78%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 2.9 s (+1.98% 🔺) 3.8 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 6.1 s (+5.54% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 351 ms (+150.47% 🔺) 463 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (-34.25% 🔽) 51 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 776 ms (+35.21% 🔺) 1.2 s

@gregfromstl
Copy link
Member

@GWSzeto could you reference a linear ticket in the description

@gregfromstl gregfromstl changed the title UI for crosschain modules [Dashboard] Feature: UI for crosschain modules Nov 13, 2024
const { contract } = info;

if (contract.chain.id === localhost.id) {
return <div>asd</div>;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the placeholder asd with a descriptive message that communicates the localhost limitation to users, such as Cross-chain deployment is not available on localhost networks

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 01:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 01:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 01:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 17, 2025 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 11:48 Inactive
Comment on lines +59 to +67
amounts: z.object({
"84532": z.string(),
"11155420": z.string(),
"919": z.string(),
"111557560": z.string(),
"999999999": z.string(),
"11155111": z.string(),
"421614": z.string(),
}),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chain ID 111557560 appears in the form schema's amounts object but is not present in the topOPStackTestnetChainIds array defined later in the code. To maintain consistency between the form validation and available chains, this chain ID should be removed from the schema.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants