-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Feature: UI for crosschain modules #5399
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5399 +/- ##
==========================================
- Coverage 54.85% 54.83% -0.03%
==========================================
Files 1142 1142
Lines 60928 60985 +57
Branches 5140 5145 +5
==========================================
+ Hits 33424 33440 +16
- Misses 26777 26819 +42
+ Partials 727 726 -1
*This pull request uses carry forward flags. Click here to find out more.
|
size-limit report 📦
|
@GWSzeto could you reference a linear ticket in the description |
apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/cross-chain/page.tsx
Outdated
Show resolved
Hide resolved
const { contract } = info; | ||
|
||
if (contract.chain.id === localhost.id) { | ||
return <div>asd</div>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the placeholder asd
with a descriptive message that communicates the localhost limitation to users, such as Cross-chain deployment is not available on localhost networks
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
amounts: z.object({ | ||
"84532": z.string(), | ||
"11155420": z.string(), | ||
"919": z.string(), | ||
"111557560": z.string(), | ||
"999999999": z.string(), | ||
"11155111": z.string(), | ||
"421614": z.string(), | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chain ID 111557560
appears in the form schema's amounts
object but is not present in the topOPStackTestnetChainIds
array defined later in the code. To maintain consistency between the form validation and available chains, this chain ID should be removed from the schema.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
https://linear.app/thirdweb/project/[modular-contracts]-op-interoperability-module-87740e1390a9/overview
PR-Codex overview
This PR introduces new features and updates related to cross-chain functionality in the
thirdweb
package, including new exports, improved contract deployment methods, and enhancements to the dashboard components for better handling of cross-chain contracts.Detailed summary
getDeployedCloneFactoryContract
.moduleInstalledEvent
.next-env.d.ts
.TWCloneFactory
.keccak256
result handling to useUint8Array
.installPublishedModule
.deployViaAutoFactory
.ProxyDeployedV2
.