allow anyone to execute the payout of an auction #357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the auction creator can execute the payout of an auction. Since there is no logic in the contract that would send the funds anywhere other than the auction creator, we should allow anyone to execute this function.
This is useful for when the buyer wants to receive the NFT upon the end of an auction, the buyer has the option for the seller to be paid out in the same transaction.
It is especially useful because there doesn't seem to be a straight-forward way for a front-end dapp to know if the buyer has only closed the auction for themselves in which case the sdk's function for ("executeSale")[https://portal.thirdweb.com/typescript/sdk.englishauctions#executesale] will fail. By allowing anyone to close out the entire auction, dapps can show the "executeSale" button to all users and they will all be able to execute it.