Add optional metadata URI to registry.add() #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+29
to
+47
| function add( | ||
| address _deployer, | ||
| address _deployment, | ||
| uint256 _chainId, | ||
| string memory metadataUri | ||
| ) external { | ||
| require(hasRole(OPERATOR_ROLE, _msgSender()) || _deployer == _msgSender(), "not operator or deployer."); | ||
|
|
||
| bool added = deployments[_deployer][_chainId].add(_deployment); | ||
| require(added, "failed to add"); | ||
|
|
||
| chainIds.add(_chainId); | ||
|
|
||
| if (bytes(metadataUri).length > 0) { | ||
| addressToMetadataUri[_chainId][_deployment] = metadataUri; | ||
| } | ||
|
|
||
| emit Added(_deployer, _deployment, _chainId, metadataUri); | ||
| } |
Check warning
Code scanning / Slither
Unused return
| } | ||
| } | ||
|
|
||
| function getMetadataUri(uint256 _chainId, address _deployment) external view returns (string memory metadataUri) { |
Check warning
Code scanning / Slither
Variable names too similar
| // slither-disable-next-line similar-names | ||
| function remove( | ||
| address _deployer, | ||
| address _deployment, |
Check warning
Code scanning / Slither
Variable names too similar
| // slither-disable-next-line similar-names | ||
| function add( | ||
| address _deployer, | ||
| address _deployment, |
Check warning
Code scanning / Slither
Variable names too similar
Check warning
Code scanning / Slither
Variable names too similar
| /// @notice Add a deployment for a deployer. | ||
| function add( | ||
| address _deployer, | ||
| address _deployment, |
Check warning
Code scanning / Slither
Variable names too similar
| /// @notice Remove a deployment for a deployer. | ||
| function remove( | ||
| address _deployer, | ||
| address _deployment, |
Check warning
Code scanning / Slither
Variable names too similar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.