Drop interfaces token structure #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+201
to
+221
| function verifyCallResult( | ||
| bool success, | ||
| bytes memory returndata, | ||
| string memory errorMessage | ||
| ) internal pure returns (bytes memory) { | ||
| if (success) { | ||
| return returndata; | ||
| } else { | ||
| // Look for revert reason and bubble it up if present | ||
| if (returndata.length > 0) { | ||
| // The easiest way to bubble the revert reason is using memory via assembly | ||
|
|
||
| assembly { | ||
| let returndata_size := mload(returndata) | ||
| revert(add(32, returndata), returndata_size) | ||
| } | ||
| } else { | ||
| revert(errorMessage); | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Assembly usage
| // SPDX-License-Identifier: MIT | ||
| // OpenZeppelin Contracts (last updated v4.5.0) (utils/Multicall.sol) | ||
|
|
||
| pragma solidity ^0.8.0; |
Check warning
Code scanning / Slither
Different pragma directives are used
Comment on lines
+128
to
+139
| function functionCallWithValue( | ||
| address target, | ||
| bytes memory data, | ||
| uint256 value, | ||
| string memory errorMessage | ||
| ) internal returns (bytes memory) { | ||
| require(address(this).balance >= value, "Address: insufficient balance for call"); | ||
| require(isContract(target), "Address: call to non-contract"); | ||
|
|
||
| (bool success, bytes memory returndata) = target.call{ value: value }(data); | ||
| return verifyCallResult(success, returndata, errorMessage); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
Comment on lines
+184
to
+193
| function functionDelegateCall( | ||
| address target, | ||
| bytes memory data, | ||
| string memory errorMessage | ||
| ) internal returns (bytes memory) { | ||
| require(isContract(target), "Address: delegate call to non-contract"); | ||
|
|
||
| (bool success, bytes memory returndata) = target.delegatecall(data); | ||
| return verifyCallResult(success, returndata, errorMessage); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
Comment on lines
+60
to
+65
| function sendValue(address payable recipient, uint256 amount) internal { | ||
| require(address(this).balance >= amount, "Address: insufficient balance"); | ||
|
|
||
| (bool success, ) = recipient.call{ value: amount }(""); | ||
| require(success, "Address: unable to send value, recipient may have reverted"); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
Comment on lines
+157
to
+166
| function functionStaticCall( | ||
| address target, | ||
| bytes memory data, | ||
| string memory errorMessage | ||
| ) internal view returns (bytes memory) { | ||
| require(isContract(target), "Address: static call to non-contract"); | ||
|
|
||
| (bool success, bytes memory returndata) = target.staticcall(data); | ||
| return verifyCallResult(success, returndata, errorMessage); | ||
| } |
Check warning
Code scanning / Slither
Low-level calls
joaquim-verges
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.