Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added pokevanilla js project #842

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: added pokevanilla js project #842

merged 1 commit into from
Oct 31, 2023

Conversation

trishan9
Copy link
Contributor

@trishan9 trishan9 commented Oct 10, 2023 •
edited
Loading

Developer Checklist

  • Followed guidelines mentioned in the readme file.
  • Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • Starred ⭐ the Repo (Optional)

Summary

add a summary here

Screenshot

attach screenshots/gifs here

Live Project Link

add a working project link here

@PBJI
Copy link
Collaborator

PBJI commented Oct 11, 2023

@trishan9 please comment project screenshots here, for review purposes.

@PBJI PBJI added the changeRequested The requested changes should be adhered to before further review or approval. label Oct 11, 2023
@trishan9
Copy link
Contributor Author

Here is the link of hosted project: https://trishan9.github.io/PokeVanilla/

@trishan9
Copy link
Contributor Author

Here is the screenshot of the project:
Screenshot from 2023-10-12 10-21-32

@trishan9
Copy link
Contributor Author

Please review @PBJI

@PBJI
Copy link
Collaborator

PBJI commented Oct 12, 2023

Hi @trishan9, it seems your project is similar to the other project called Pokedex, so please consider renaming it to Pokedex and I'll review it for merging

Thank you.

@NitkarshChourasia
Copy link
Collaborator

@trishan9 too bright, do add dark mode.

NitkarshChourasia
NitkarshChourasia approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time use fontawesome 5, it is good.

NitkarshChourasia
NitkarshChourasia requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a README.md file with a screenshot embedded to it.

@thinkswell thinkswell merged commit eeb1181 into thinkswell:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NitkarshChourasia NitkarshChourasia NitkarshChourasia requested changes

Assignees
No one assigned
Labels
changeRequested The requested changes should be adhered to before further review or approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trishan9 @PBJI @NitkarshChourasia @thinkswell