Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ludo implementation #1170

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

Jayasri2111
Copy link
Contributor

Developer Checklist

  • [Yes ] Followed guidelines mentioned in the readme file.
  • [Yes ] Followed directory structure. (e.g. ProjectName/{USERNAME}/...yourfiles)
  • [Yes ] Starred ⭐ the Repo (Optional)

Summary

This project is a web-based Ludo game where players can compete against each other in a classic Ludo board game experience.

Screenshot

Ludo image

Live Project Link

https://ludo-champs.netlify.app/

@Jayasri2111
Copy link
Contributor Author

Hello @NitkarshChourasia
Please copy the live demo link and paste it in browser so it will work.

@NitkarshChourasia
Copy link
Collaborator

@Jayasri2111 Therre are lot of logical errors.
Like it gives me lot of chances to play if I have not clicked any pawns of mine.
And I think the range function is missing in other players because after trying 100 of times.
Other players are not able to open up.
@Jayasri2111
Also do follow me on other social media handles including GitHub.

https://www.linkedin.com/in/nitkarshchourasia/

Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it is good.
Just improve the logical part.
Thank you.

@Jayasri2111
Copy link
Contributor Author

Hi @NitkarshChourasia,
This is part of my assignment, and my team and I have worked hard to implement the project up to this point. The project looks great overall, aside from the issues you pointed out. I’ve uploaded the code to my GitHub repository and marked it open for contributions. I’ll raise these issues there, and if I receive suitable solutions, I’ll include them in the project. Thank you!

@NitkarshChourasia
Copy link
Collaborator

Hi @NitkarshChourasia,
This is part of my assignment, and my team and I have worked hard to implement the project up to this point. The project looks great overall, aside from the issues you pointed out. I’ve uploaded the code to my GitHub repository and marked it open for contributions. I’ll raise these issues there, and if I receive suitable solutions, I’ll include them in the project. Thank you!

I'll check and merge in the morning. +05:30 I.S.T (INDIA)
Salute to you and your team for the hard-work.
Way to go to become a successful developer.

Copy link
Collaborator

@NitkarshChourasia NitkarshChourasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jayasri2111 Just do one more thing.
Sort the files into directories like static/js/files.js
static/images/files.png

Learn directory based sorting to enable scalable structure
@Jayasri2111 Thank you.
I'll merge for now.
But hope you will do the following.

@NitkarshChourasia
Copy link
Collaborator

@Jayasri2111 Just do one more thing.
Sort the files into directories like static/js/files.js
static/images/files.png

Learn directory based sorting to enable scalable structure
@Jayasri2111 Thank you.
I'll merge for now.
But hope you will do the following.

@NitkarshChourasia NitkarshChourasia merged commit 27ee633 into thinkswell:master Dec 5, 2024
@NitkarshChourasia
Copy link
Collaborator

@Jayasri2111 Do follow me on regular updates on my projects and programming -world :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants