fix: Stop chowning in tedge-agent #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bravo555
requested review from
didier-wenzek,
albinsuresh,
jarhodes314,
rina23q,
gligorisaev and
a team
as code owners
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
Robot Results
|
Bravo555
force-pushed
the
fix/3143/collectd-config-permission
branch
from
b382473
to
c3da4c7
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
force-pushed
the
fix/3143/collectd-config-permission
branch
from
c3da4c7
to
e92db8f
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
changed the title
Bravo555
force-pushed
the
fix/3143/collectd-config-permission
branch
from
e92db8f
to
e01d391
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Stop setting file ownership in tedge-agent, which runs as `tedge` user. Also added a missing test for a case when a file is owned by root. Setting file ownership is a privileged operation, which should be done by tedge-write. It's also unnecessary to change permissions on a temporary file which is atomically moved into destination by config-manager anyway. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
force-pushed
the
fix/3143/collectd-config-permission
branch
from
e01d391
to
fcd1679
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Tried to merge 2 times, 3 tests failed, but they don't repeat across both tries, seems they're flakes? Going to test them with flake-finder:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Stop setting file ownership in tedge-agent, which runs as
tedgeuser. Also added a missing test for a case when a file is owned by root.Setting file ownership is a privileged operation, which should be done by tedge-write. It's also unnecessary to change permissions on a temporary file which is atomically moved into destination by config-manager anyway.
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments
This change should resolve the issue and is small, so it'd be good to merge it ASAP. It resolves first 2 points of #3143 (comment), i.e. adds missing test case and removes the usage of
chownwhile running astedge.We still unnecessarily leave temporary files, but that will be done in a follow-up PR.