Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate build jobs #2910

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented May 30, 2024

Proposed changes

Add ci checks to validate if any of the build matrix jobs was marked as failed, cancelled, or skipped.

It has been observed that if a Github Runner fails on one of the build matrix jobs, it can lead to the job being skipped, which in turns is treated by the workflow as a "don't care". This leads to the publishing jobs only partially publishing all of the expected packages (from those build jobs which passed), see an example .

References:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2908

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (613e8dd) to head (0b974d5).
Report is 1 commits behind head on main.

Additional details and impacted files

see 2 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented May 30, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
444 0 3 444 100 1h2m11.311539s

@reubenmiller reubenmiller added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added this pull request to the merge queue May 30, 2024
Merged via the queue into thin-edge:main with commit 07370d2 May 30, 2024
32 checks passed
@reubenmiller reubenmiller deleted the ci-check-build-job branch July 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants