Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add explicit dependency on build job #2909

Merged
merged 1 commit into from
May 30, 2024

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented May 30, 2024

Proposed changes

Note: still needs to be tested by running through the merge queue

Prevent progression of the workflow if a build job is cancelled or skipped.

Without a direct link to the publish and build jobs, the publish was previously triggered if the test job was marked as skipped (due to its upstream job being not marked as "success").

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2908

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Prevent progression of the workflow if a build job is cancelled or skipped.

Resolves thin-edge#2908

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (05a644e) to head (613e8dd).
Report is 5 commits behind head on main.

Additional details and impacted files

see 5 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
444 0 3 444 100 1h0m46.519414s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue May 30, 2024
@reubenmiller reubenmiller removed this pull request from the merge queue due to a manual request May 30, 2024
@reubenmiller reubenmiller added this pull request to the merge queue May 30, 2024
@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label May 30, 2024
Merged via the queue into thin-edge:main with commit f6b3ee3 May 30, 2024
32 checks passed
@reubenmiller reubenmiller deleted the ci-explicit-build-dep branch July 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants