Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual interface orientation instead of the device one #226

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Use actual interface orientation instead of the device one #226

merged 1 commit into from
Jan 14, 2017

Conversation

kjen93
Copy link
Contributor

@kjen93 kjen93 commented Jan 10, 2017

Use actual interface orientation instead of the device one to fix misplaced progress view when orientations do not match

Progress view is misplaced when the device is in landscape orientation, but application is portrait-only.

…placed progress view when orientations do not match

Progress view is misplaced when the device is in landscape orientation, but application does not support it.
@eduardocallado eduardocallado merged commit 79e1157 into thiagoperes:master Jan 14, 2017
@kjen93 kjen93 deleted the kjen93-progressview-misplaced-when-app-is-portrait-only branch January 14, 2017 14:02
@jackie-li
Copy link

Progress view is still misplaced on devices that run on iOS 8+
Since iOS 8, [UIScreen mainScreen].bounds is orientation-dependent, this solution is incorrect when devices run on iOS 8+.
Below screenshot is captured from iPad simulator iOS 10.2 with IDMPhotoBrowser 1.11.1:
loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants