fix: stop factory creating unused initial association #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagomini
requested changes
Jul 30, 2024
| @@ -488,6 +490,58 @@ describe('Factory', () => { | |||
| expect(address).toMatchObject(addressAttributes); | |||
| expect(address.userId).toBe(userAttributes.id); | |||
| }); | |||
|
|
|||
| it('it should not create overridden associations', async () => { | |||
There was a problem hiding this comment.
This feature is something that is not exclusive to Sequelize, so it'd be better to test it with the Object Adapter (which is more database-agnostic). If you want to double check this is not creating a new entry in the database when used with Sequelize, I advise also adding a test to the sequelize-specific test suite
There was a problem hiding this comment.
@thiagomini sorry I didn't notice this for a while - I've changed it to ObjectAdapter 👍 doesn't seem like the issue was specific to sequelize so no need to put it into a specific test suite I think
|
@thiagomini just checking if there's anything left to do here or if this can get merged in? |
|
This can be merged @dkpoult , I'll create a release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveAssociationsfunction of theFactoryclass so that it first merges any provided overrides before looping through the attributes to resolve the associations - which now avoids an unexpected entry in the database when the factory resolves a model with an association for the first time.