Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "method_complexity" issue in packages/transducers/src/iter/wrap-sides.ts #166

Closed
postspectacular opened this issue Nov 8, 2019 · 0 comments
Closed

Fix "method_complexity" issue in packages/transducers/src/iter/wrap-sides.ts #166

postspectacular opened this issue Nov 8, 2019 · 0 comments
Labels
codeclimate refactor

Comments

@postspectacular
Copy link
Member

Function wrapSides has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

https://codeclimate.com/github/thi-ng/umbrella/packages/transducers/src/iter/wrap-sides.ts#issue_5dc5e13fe161a90001000936
postspectacular added a commit that referenced this issue Nov 10, 2019
@postspectacular
Merge branch 'develop' into feature/rstream-opts
ec3f2c8 
* develop: (122 commits)
  build: update make-module script
  build: force typescript version for docs build
  Publish
  docs(hiccup-markdown): add note about #156 to readme
  refactor(associative): fix #169, update set op reducers
  refactor(malloc): fix #163, extract splitBlock() method
  refactor(simd): fix #162, update normalize2_f32_aos()
  fix(examples): update PARAMS transducer (TS inferencer issue)
  refactor(color): update multiCosineGradient()
  refactor(transducers): update tween() args
  refactor(transducers): fix #166, update wrapSides() bounds check
  refactor(api): fix #168, refactor Range types
  docs: update main readme
  chore: remove branch thi.ng metadata from pkgs
  docs(associative): update readme & pkg keywords
  fix(associative): fix off-by-one error in sparseSet() factory, add tests
  docs(hdom-canvas): update readme, fix TOC
  docs(simd): update readme
  docs(soa): update readme
  docs(vector-pools): update readme
  ...
postspectacular added a commit that referenced this issue Nov 10, 2019
@postspectacular
Merge branch 'develop' into feature/scenegraph
162a771 
* develop: (122 commits)
  build: update make-module script
  build: force typescript version for docs build
  Publish
  docs(hiccup-markdown): add note about #156 to readme
  refactor(associative): fix #169, update set op reducers
  refactor(malloc): fix #163, extract splitBlock() method
  refactor(simd): fix #162, update normalize2_f32_aos()
  fix(examples): update PARAMS transducer (TS inferencer issue)
  refactor(color): update multiCosineGradient()
  refactor(transducers): update tween() args
  refactor(transducers): fix #166, update wrapSides() bounds check
  refactor(api): fix #168, refactor Range types
  docs: update main readme
  chore: remove branch thi.ng metadata from pkgs
  docs(associative): update readme & pkg keywords
  fix(associative): fix off-by-one error in sparseSet() factory, add tests
  docs(hdom-canvas): update readme, fix TOC
  docs(simd): update readme
  docs(soa): update readme
  docs(vector-pools): update readme
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codeclimate refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@postspectacular