naming is hard

thezanke · Aug 29, 2023 · 2ff2318 · 2ff2318
1 parent f6ec39d
commit 2ff2318
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/chat/chat.service.ts b/src/chat/chat.service.ts
@@ -21,18 +21,21 @@ export class ChatService {
   }
 
   private async handleMention(initialMessage: Message) {
-    const messages: CreateChatCompletionRequestMessage[] = [];
-    const chain = this.discordService.messageChainGenerator(initialMessage);
+    const discordMessages =
+      this.discordService.messageChainGenerator(initialMessage);
 
-    for await (const message of chain) {
-      messages.push(
+    const openAIMessages: CreateChatCompletionRequestMessage[] = [];
+
+    for await (const message of discordMessages) {
+      openAIMessages.push(
         createUserMessage(message.content, message.author.username),
       );
     }
 
-    messages.reverse();
+    // faster to reverse at the end than to unshift
+    openAIMessages.reverse();
 
-    const response = await this.openAIChatService.getCompletion(messages);
+    const response = await this.openAIChatService.getCompletion(openAIMessages);
 
     await initialMessage.reply(response);
   }