Add a temporary hack to always generate sha512 prefixed artifacts #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done even if sha512 is not used in the metadata: * sigstore-java assumes this prefix is used * this temporary fix means sigstore root-signing does not need to break a client without warning
|
I've tested, seems to work. I think we could consider:
|
jku
force-pushed
the
add-hack-for-sigstore-java
branch
from
06c0715
to
ddbd7aa
Compare
|
making draft in light of current discussion in sigstore/root-signing-staging#161: maybe we don't need this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done even if sha512 is not used in the metadata:
Leaving this a draft until I've tested