The Big Rename #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playground -> tuf-on-ci * variable and class names * directories * packages/modules * the signer configuration file * custom metadata field names This is very incompatible with any existing repositories. It may be possible to create a playground2tuf-on-ci import script but this is not included here. Also remove the downloader client code for now -- We should have an example but A) it should be clearly an example, not part of the code release B) the old code had a lot of unrelated things
File locations have changed compared to repository-playground
|
Annoyingly I would need to add extra permissions to the CI workflow to get it to run on a private repo. EDIT: fixed by adding the permission: I think it's appropriate |
|
related template PR theupdateframework/tuf-on-ci-template#1 |
This is by default on for public repos but not for private ones
|
Going over the files now. Started with a quick kommendorkapten@m1m14:~/git/tuf-on-ci % find . -type f | xargs grep -i playground
./LICENSE:Copyright 2022-2023 repository-playground contributors
./README.md:[example](https://github.com/jku/test-repo-for-playground/) for an instance running TUF-on-CI.
./repo/test/test_repo1/root.json: "x-tuf-on-ci-keyowner": "@playgrounduser1" |
|
So I believe the |
|
Tests came out clean: kommendorkapten@m1m14:~/git/tuf-on-ci/tests % ./e2e.sh
Basic repository initialization... OK
Online version bump... OK
Multiuser signing... OK
Target file changes... OK
Root key rotation... OK |
If you're referring to the copyright notices, I think they're correct: the code is copyright repository-playground contributors even if it has been moved to the tuf-on-ci repo... Let me know if you meant something else |
This does not affect the test in any way
kommendorkapten
approved these changes
Jul 18, 2023
|
I'll merge: I'm sure there are still issues but system testing will be a lot easier after the merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename repository-playground to tuf-on-ci
Notes: