Use the keyids and threshold set by delegating roles to verify delegated metadata #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
… roles_names Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
3 tasks
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>
|
Due to imminent refactor efforts this code is unlikely to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Addresses #660, #590, #589, and #658.
Description of the changes being introduced by the pull request:
This pull request verifies the signature(s) in targets metadata by using the
keyidsandthresholdset by the delegating role (or in the case of the top-level targets role, thekeyidsandthresholdspecified in the root metadata file).Note: The unit tests in #590 (WIP) should be merged with this fix to verify the expected behavior.
Please verify and check that the pull request fulfills the following
requirements:
Signed-off-by: Vladimir Diaz <vladimir.v.diaz@gmail.com>