ngclient: use Metadata.verify_delegate #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVrachev
approved these changes
Jul 26, 2021
joshuagl
reviewed
Jul 27, 2021
| @@ -408,7 +360,7 @@ def update_delegated_targets( | |||
| if self.snapshot is None: | |||
| raise RuntimeError("Cannot load targets before snapshot") | |||
|
|
|||
| delegator = self.get(delegator_name) | |||
| delegator: Optional[Metadata] = self.get(delegator_name) | |||
There was a problem hiding this comment.
Are we annotating this as Optional so that mypy can understand that None is a valid value for delegator? Why wasn't this required before?
There was a problem hiding this comment.
No, mypy was not complaining about this. I did it to help the code editor figure it out. I can separate it in another commit or explain it in the commit message if it looks weird in between the other changes.
There was a problem hiding this comment.
It does look a bit out of place in this commit, though it's not an objectionable change by itself.
Replace the helper verify_with_threshold() with the newly implemented method Metadata.verify_delegate. Add an aditional type annotation helping the IDE. Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
sechkova
force-pushed
the
use_verify_with_threshold
branch
from
7a370e5
to
d70f697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1413
Description of the changes being introduced by the pull request:
Replace the helper verify_with_threshold() with
the newly implemented method Metadata.verify_delegate.
Please verify and check that the pull request fulfills the following
requirements: