ADR 8: change "Decision outcome" #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a discussion with Jussi, we realized that there are a couple of places where we don't want to allow unrecognized fields because the they are sensitive dictionaries and the specification requires an items of certain types inside them. The places where we don't want to allow unrecognized fields are "keys", "roles", "meta", "hashes" or "targets". Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
|
@jku can you review that pr given that we have discussed unrecognized fields support with you in a couple of prs and issues. |
jku
approved these changes
Sep 7, 2021
|
🤷 well I merged it |
|
I think that was appropriate. The goal of ADRs is to provide design documentation and make implicit assumptions explicit, so updating ADRs to capture nuance like this seems sensible to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes being introduced by the pull request:
After a discussion with Jussi, we realized that there are a couple of
places where we don't want to allow unrecognized fields because the
they are sensitive dictionaries and the specification requires an items
of certain types inside them.
The places where we don't want to allow unrecognized fields are
"keys", "roles", "meta", "hashes" or "targets".
This is pr is updating ADR8 with the decision we already take in #1466.
Signed-off-by: Martin Vrachev mvrachev@vmware.com