Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngclient constants and configuration #1470

Merged
merged 3 commits into from
Jul 7, 2021

Commits on Jul 5, 2021

  1. Add client config module

    Add a config module containing a dataclass
    UpdaterConfig with all client settings.
    Initialize updater with default settings
    if no other condig is provided.
    
    Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    sechkova committed Jul 5, 2021
    Configuration menu
    Copy the full SHA
    a50e76d View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Rename UpdaterConfig attributes

    Since configuration constants are now part of a
    config class, make them lower case. This also avoids
    pylint's invalid-name error for class attributes.
    
    Remove the 'default' prefix as they are now configurable
    options.
    
    Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    sechkova committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    520b344 View commit details
    Browse the repository at this point in the history
  2. Add RequestsFetcher settings as attributes

    Stop using the settings module and add the RequestsFetcher
    specific config as instance attributes.
    Users of the requests-based fetcher implementation can
    modify them after instantiating a RequestsFetcher
    object if needed.
    
    Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
    sechkova committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    37defa9 View commit details
    Browse the repository at this point in the history