minor comments

Signed-off-by: Trishank Karthik Kuppusamy <trishank.kuppusamy@datadoghq.com>

tests/test_tuf_api.py

@@ -307,6 +307,7 @@ def test(key_type, hash_algorithm, hash_algorithms):
     )
 
     # FIXME: Unfortunately, py-TUF does not yet support P-384.
+    # https://github.com/hvac/hvac/pull/606
     # test(
     #   VaultKey.KeyTypes.P_384.value,
     #   VaultKey.HashAlgorithms.SHA2_384.value,
@@ -336,8 +337,8 @@ def test_VaultKey_RSA(self):
 
     for key_type in {
       VaultKey.KeyTypes.RSA_2048.value,
-      # FIXME: https://github.com/hvac/hvac/issues/605
-      #VaultKey.KeyTypes.RSA_3072.value,
+      # https://github.com/hvac/hvac/issues/605
+      VaultKey.KeyTypes.RSA_3072.value,
       VaultKey.KeyTypes.RSA_4096.value
     }:
       NAME = f'test-{key_type}-key'

tuf/api/keys.py

@@ -308,8 +308,7 @@ def __init__(
         if not self.__client.is_authenticated():
             raise self.AuthenticationError
 
-        # Guess why this isn't a requests.Response?
-        # https://github.com/hvac/hvac/pull/537#issuecomment-660304707
+        # https://github.com/hvac/hvac/issues/604
         response = self.__client.secrets.transit.read_key(name=name)
         self.__name = name
 
@@ -324,8 +323,6 @@ def __init__(
         # NOTE: The documentation is not clear, but presumably the returned
         # keys are different versions of keys under the same name. Therefore,
         # we shall select the one with the latest version number.
-        # NOTE: We are also taking it for granted that Vault will generate
-        # public keys in formats TUF will recognize out of the box.
         keys = data['keys']
         latest_version = data['latest_version']
         key = keys.get(str(latest_version))
@@ -420,6 +417,7 @@ def verify(self, signed: BytesOrStr, signature: Dict) -> bool:
             self.KeyTypes.RSA_3072.value,
             self.KeyTypes.RSA_4096.value
         } and self.__signature_algorithm == self.SignatureAlgorithms.PSS.value:
+            # https://github.com/secure-systems-lab/securesystemslib/pull/262
             return self.__ram_key._verify_rsa_signature(
                 signed,
                 signature,