Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use SHA384 for ECDSA P384 #629

Merged

Conversation

mrjoelkamp
Copy link
Contributor

@mrjoelkamp mrjoelkamp commented Apr 1, 2024

Handle hash algorithm selection for ecdsa-sha2-nistp384

fixes #628

Signed-off-by: mrjoelkamp <joel.kamp@docker.com>
@mrjoelkamp mrjoelkamp force-pushed the fix-use-sha-384-for-ecdsa-p384 branch from c735675 to 5fe820a Compare April 1, 2024 20:07
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC this was done this way as technically the spec did not list any other key schemes, but in any case it's good to support more 👍

Thanks! @mrjoelkamp 🚀

@rdimitrov rdimitrov merged commit a5740b4 into theupdateframework:master Apr 2, 2024
23 checks passed
@mrjoelkamp mrjoelkamp deleted the fix-use-sha-384-for-ecdsa-p384 branch April 2, 2024 15:51
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.94%. Comparing base (14cf073) to head (4b9db35).
Report is 20 commits behind head on master.

Files Patch % Lines
metadata/metadata.go 42.85% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   70.51%   72.94%   +2.43%     
==========================================
  Files          10       10              
  Lines        2123     1656     -467     
==========================================
- Hits         1497     1208     -289     
+ Misses        505      327     -178     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: hash algorithm defaults to SHA256 for most algorithms
4 participants