Refactor errors to use pointer receivers #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Soyland <codysoyland@github.com>
codysoyland
force-pushed
the
error-pointers
branch
from
06838e4
to
127dd7c
Compare
codysoyland
commented
Feb 5, 2024
rdimitrov
approved these changes
Feb 5, 2024
|
@codysoyland - That's nice! 💯 Thank you for addressing this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all errors to use pointer receivers, as is common Go idiom.
This doesn't change any behavior. It started as my attempt to fix something I thought was a bug, but I think I misunderstood. I won't feel bad if you decide to close/reject as this doesn't change any behavior and introduces a lot of LoC changes.
Pointer receivers have some benefits for use in error handling -- notably you can compare errors to nil (
if err == nilvsif err == MyError{}). The choice is somewhat arbitrary, but using pointers is far more conventional.