ci(build): Add arm64 to build #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems legit, thanks! Let me try to get more reviewers... |
trishankatdatadog
approved these changes
Feb 22, 2023
rdimitrov
reviewed
Feb 22, 2023
There was a problem hiding this comment.
Hey, @udf2457, thank you for your contribution 👋
As far as cross-building and releasing the images go, I think this should be enough from the goreleaser side 👍
It's worth mentioning though that we don't run our CI (thus our tests) on anything else other than the x86_64-based runner provided by GitHub. So until we either add a self-hosted runner or maybe emulate the aarch64 environment we won't run any tests on an aarch64 architecture.
rdimitrov
approved these changes
Apr 6, 2023
znewman01
approved these changes
Apr 7, 2023
add `arm64` to `goarch` Signed-off-by: udf2457 <udf2457@users.noreply.github.com>
add `arm64` to `goarch` Signed-off-by: udf2457 <udf2457@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #461.
Note that I'm no build process expert, but I reckon this should work. ;-)