Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update lint CI parameters #394

Merged
merged 1 commit into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. tests: update lint CI parameters

    Context: linting in CI (`golangci-lint`) occasionally times out on
    Windows (flaky). Most of the time, it's fast enough (~1min). But
    occasionally it hits the 3 minute timeout. It's somewhat expected that
    `golangci-lint` is slow:
    
    golangci/golangci-lint-action#297
    
    This PR does 3 things:
    
    1. Bump the timeout from 3 to 5 minutes (why solve the problem when you
       can band-aid it?)
    2. Add the `--verbose` flag, so if we start to see this again we'll have
       much better information with which to figure out what specifically is
       taking so long.
    3. Remove the patch number from the `golangci-lint` version; it's
       disallowed, according to the `golangci-lint` action README.
    
    Fixes theupdateframework#390 (for now).
    
    Signed-off-by: Zachary Newman <z@znewman.net>
    znewman01 committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    767dfbe View commit details
    Browse the repository at this point in the history