Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commit without adding targets #238

Merged

Conversation

znewman01
Copy link
Contributor

By making init write an empty targets.json.

The following didn't work before but now does:

tuf init

tuf gen-key root
tuf gen-key targets
tuf gen-key snapshot
tuf gen-key timestamp

tuf sign root.json
# you used to need a `tuf add` here
tuf sign targets.json

tuf snapshot
tuf timestamp

tuf commit

By making `init` write an empty `targets.json`.
@coveralls
Copy link

coveralls commented Mar 20, 2022

Pull Request Test Coverage Report for Build 2011993102

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.9%) to 74.645%

Changes Missing Coverage Covered Lines Changed/Added Lines %
repo.go 6 8 75.0%
Totals Coverage Status
Change from base Build 2000571104: 3.9%
Covered Lines: 1260
Relevant Lines: 1688

💛 - Coveralls

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this change -- this bothered me!

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @znewman01 for this. The change looks good to me, but I'd love to hear from a maintainer who's more actively using go-tuf cc @trishankatdatadog @ethan-lowman-dd @hosseinsia

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trishankatdatadog trishankatdatadog merged commit 8453bf6 into theupdateframework:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants