Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reason to ErrInvalidKeys #237

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

znewman01
Copy link
Contributor

Leads to better error messages throughout. Also improve repo_test
coverage to exercise all of the ErrInvalidKeys paths.

Signed-off-by: Zachary Newman z@znewman.net

Leads to better error messages throughout. Also improve repo_test
coverage to exercise all of the ErrInvalidKeys paths.

Signed-off-by: Zachary Newman <z@znewman.net>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2011969605

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 71.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
errors.go 0 1 0.0%
repo.go 6 8 75.0%
Totals Coverage Status
Change from base Build 2000571104: 0.7%
Covered Lines: 2279
Relevant Lines: 3193

💛 - Coveralls

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@joshuagl joshuagl merged commit 545f98e into theupdateframework:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants