[Delegations prereq 6] Use a verify.DB for delegation in client #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1918163160
💛 - Coveralls |
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
from
092aa7c
to
344f4ee
Compare
mnm678
previously approved these changes
Dec 13, 2021
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-5
branch
from
314e8de
to
ab8cfcc
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
from
344f4ee
to
3a7542d
Compare
asraa
reviewed
Dec 16, 2021
|
Would you please add some description to this PR? |
hosseinsia
reviewed
Dec 16, 2021
hosseinsia
reviewed
Dec 17, 2021
Base automatically changed from
ethan.lowman/delegations-prereq-5
to
ethan.lowman/delegations-prereq-3
January 7, 2022 16:10
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-3
branch
from
6649d88
to
372d80d
Compare
ethan-lowman-dd
changed the base branch from
ethan.lowman/delegations-prereq-3
to
ethan.lowman/delegations-prereq-5
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-5
branch
from
ab8cfcc
to
8662774
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
from
3a7542d
to
48783d0
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-5
branch
from
8662774
to
ed8955d
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
2 times, most recently
from
a39931e
to
bc74300
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
3 times, most recently
from
3cef410
to
b627120
Compare
ethan-lowman-dd
changed the base branch from
master
to
ethan.lowman/delegations-prereq-8
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
2 times, most recently
from
2e447bc
to
d1fae69
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
from
d1fae69
to
071ef19
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-6
branch
from
071ef19
to
3716bf3
Compare
…sociated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role
hosseinsia
reviewed
Mar 1, 2022
hosseinsia
previously approved these changes
Mar 1, 2022
asraa
reviewed
Mar 1, 2022
mnm678
approved these changes
Mar 4, 2022
|
@asraa This has two stamps now -- did you want to take another look before I merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #175
This PR removes the type
verify.DelegationsVerifierin favor of using averify.DBdirectly to store sets of keys. This simplifies the types, since aDelegationsVerifierjust wrapped aDBwithout adding significant functionality, and allows us to use the same type (averify.DB) to hold keys for the top level targets role as for delegated targets roles.