Add digest to targets metadata directly

[mnm678]

Allows users of go-tuf to sign oci images or other non-local targets by directly providing the hash and length of these artifacts. Solves #165

cc @ethan-lowman-dd @trishankatdatadog @sudo-bmitch

[mnm678]

hmm, the Ubuntu build is failing to install snappy. I don't think that relates to this pr, but I'm not sure what's causing it.

[joshuagl]

The build is failing in go fmt, which only runs on Linux (i.e. Ubuntu), see

go-tuf/.github/workflows/build.yml

Line 24 in fc0190d

- name: Format Unix

If I run go fmt locally on a clone of this branch it reformats repo_test.go thus:

diff --git a/repo_test.go b/repo_test.go
index bc55210..c764162 100644
--- a/repo_test.go
+++ b/repo_test.go
@@ -1684,7 +1684,7 @@ func (rs *RepoSuite) TestBadAddOrUpdateSignatures(c *C) {
        checkSigIDs("root.json")
 }

-func (rs *RepoSuite) TestSignDigest(c *C){
+func (rs *RepoSuite) TestSignDigest(c *C) {
        files := map[string][]byte{"foo.txt": []byte("foo")}
        local := MemoryStore(make(map[string]json.RawMessage), files)
        r, err := NewRepo(local)
@@ -1708,7 +1708,7 @@ func (rs *RepoSuite) TestSignDigest(c *C){
        c.Assert(err, IsNil)

        targets, err := r.targets()
-               c.Assert(err, IsNil)
+       c.Assert(err, IsNil)
        c.Assert(targets.Targets["sha256:bc11b176a293bb341a0f2d0d226f52e7fcebd186a7c4dfca5fc64f305f06b94c"].FileMeta.Length, Equals, size)
        c.Assert(targets.Targets["sha256:bc11b176a293bb341a0f2d0d226f52e7fcebd186a7c4dfca5fc64f305f06b94c"].FileMeta.Hashes["sha256"], DeepEquals, hex_digest_bytes)

[mnm678]

Thank for the review @ethan-lowman-dd!

[coveralls]

Pull Request Test Coverage Report for Build 1719253116

• 26 of 41 (63.41%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 70.28%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
repo.go	17	24	70.83%
client/client.go	9	17	52.94%

Totals
Change from base Build 1695351458:	-0.1%
Covered Lines:	2159
Relevant Lines:	3072

---

💛 - Coveralls

[mnm678]

I added the client verification and fixed the test failures, so I think this is ready for another review @ethan-lowman-dd or @trishankatdatadog

[trishankatdatadog]

I added the client verification and fixed the test failures, so I think this is ready for another review @ethan-lowman-dd or @trishankatdatadog

Awesome! Ethan, would you please help? 🙂

[mnm678]

ping @trishankatdatadog you're marked as requesting changes. Do the latest commits address those?

[trishankatdatadog]

ping @trishankatdatadog you're marked as requesting changes. Do the latest commits address those?

Will review today during our meeting. Thanks!

[mnm678]

Thanks @asraa. I addressed your comments and rebased for some of the delegations pr changes.