Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why recast ErrUnknownTarget as ErrNotFound? #156

Closed
trishankatdatadog opened this issue Sep 17, 2021 · 1 comment
Closed

Why recast ErrUnknownTarget as ErrNotFound? #156

trishankatdatadog opened this issue Sep 17, 2021 · 1 comment
Labels
enhancement good first issue

Comments

@trishankatdatadog
Copy link
Member

It appears that sometimes, the client API recasts ErrUnknownTarget as ErrNotFound. This seems unnecessary: there should be only one canonical error.
@trishankatdatadog trishankatdatadog mentioned this issue Sep 17, 2021
Merged
@znewman01 znewman01 mentioned this issue Jun 9, 2022
Closed
@rdimitrov
Copy link
Contributor

Closing since the code base changed and so this is no longer valid.

Thanks for raising this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdimitrov @trishankatdatadog