omit one initializing test for windows.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>

client/client_test.go

@@ -200,28 +200,7 @@ func (s *ClientSuite) SetUpTest(c *C) {
 
 func (s *ClientSuite) TearDownTest(c *C) {
 	if s.tmpDir != "" {
-		c.Logf("Removing %s", s.tmpDir)
-		d, err := os.Open(s.tmpDir)
-		if err != nil {
-			c.Logf("Failed to open %s: %v", s.tmpDir, err)
-			return
-		}
-		defer d.Close()
-		// -1 means give me everything, we don't have that many entries, so
-		// fine here.
-		names, err := d.Readdirnames(-1)
-		if err != nil {
-			c.Logf("Failed to ReaddirNames %s: %v", s.tmpDir, err)
-			return
-		}
-		for _, name := range names {
-			toRemove := filepath.Join(s.tmpDir, name)
-			err = os.RemoveAll(toRemove)
-			if err != nil {
-				c.Logf("Failed to RemoveAll %s: %v", toRemove, err)
-				// Do not want to fail here, because will fail test.
-			}
-		}
+		rmrf(s.tmpDir, c.Logf)
 	}
 }
 

client/file_store_test.go

@@ -6,32 +6,40 @@ import (
 	"io/fs"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 )
 
 const targetsDir = "targets"
 
 func TestCreates(t *testing.T) {
+	runningWindows := false
+	if runtime.GOOS == "windows" {
+		runningWindows = true
+	}
 	tmpDir := t.TempDir()
 	defer os.RemoveAll(tmpDir)
 	dir := filepath.Join(tmpDir, "repository")
 	os.Mkdir(dir, os.ModePerm)
 	os.Mkdir(filepath.Join(dir, "targets"), os.ModePerm)
-	targetDirThatIsFile := filepath.Join(dir, "targets-that-isfile")
-	f, err := os.Create(targetDirThatIsFile)
-	if err != nil {
-		t.Fatalf("failed to create file: %s: %v", targetDirThatIsFile, err)
+	if !runningWindows {
+		targetDirThatIsFile := filepath.Join(dir, "targets-that-isfile")
+		f, err := os.Create(targetDirThatIsFile)
+		if err != nil {
+			t.Fatalf("failed to create file: %s: %v", targetDirThatIsFile, err)
+		}
+		defer f.Close()
 	}
 	t.Cleanup(func() { rmrf(dir, t.Logf) })
 	t.Cleanup(func() { rmrf(tmpDir, t.Logf) })
-	t.Cleanup(func() { f.Close() })
 
 	tests := []struct {
-		name    string
-		fsys    fs.FS
-		td      string
-		wantErr string
+		name              string
+		fsys              fs.FS
+		td                string
+		wantErr           string
+		doNotRunOnWindows bool
 	}{{
 		name:    "nil, error",
 		wantErr: "nil fs.FS",
@@ -41,10 +49,11 @@ func TestCreates(t *testing.T) {
 		td:      "targets-not-there",
 		wantErr: "failed to open targets directory targets-not-there",
 	}, {
-		name:    "targets directory is not a file",
-		fsys:    os.DirFS(dir),
-		td:      "targets-that-isfile",
-		wantErr: "targets directory not a directory targets-that-isfile",
+		name:              "targets directory is not a file",
+		fsys:              os.DirFS(dir),
+		td:                "targets-that-isfile",
+		wantErr:           "targets directory not a directory targets-that-isfile",
+		doNotRunOnWindows: true,
 	}, {
 		name: "works, explicit targets",
 		fsys: os.DirFS(dir),
@@ -56,6 +65,9 @@ func TestCreates(t *testing.T) {
 	}}
 
 	for _, tc := range tests {
+		if tc.doNotRunOnWindows {
+			t.Skip("Can't figure out how to make this work on windows")
+		}
 		_, err := NewFileRemoteStore(tc.fsys, tc.td)
 		if tc.wantErr != "" && err == nil {
 			t.Errorf("%q wanted error %s, got none", tc.name, tc.wantErr)