Add assertion on errors of key parsing

Signed-off-by: Asra Ali <asraa@google.com>
theupdateframework · Sep 2, 2022 · 25dbbe4 · 25dbbe4
1 parent c20e18a
commit 25dbbe4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/pkg/keys/ecdsa.go b/pkg/keys/ecdsa.go
@@ -37,7 +37,12 @@ type EcdsaVerifier struct {
 
 func (p *EcdsaVerifier) Public() string {
 	// This is already verified to succeed when unmarshalling a public key.
-	r, _ := x509.MarshalPKIXPublicKey(p.ecdsaKey)
+	r, err := x509.MarshalPKIXPublicKey(p.ecdsaKey)
+	if err != nil {
+		// TODO: Gracefully handle these errors.
+		// See https://github.com/theupdateframework/go-tuf/issues/363
+		panic(err)
+	}
 	return string(r)
 }
 

diff --git a/pkg/keys/rsa.go b/pkg/keys/rsa.go
@@ -37,7 +37,12 @@ type rsaVerifier struct {
 
 func (p *rsaVerifier) Public() string {
 	// This is already verified to succeed when unmarshalling a public key.
-	r, _ := x509.MarshalPKIXPublicKey(p.rsaKey)
+	r, err := x509.MarshalPKIXPublicKey(p.rsaKey)
+	if err != nil {
+		// TODO: Gracefully handle these errors.
+		// See https://github.com/theupdateframework/go-tuf/issues/363
+		panic(err)
+	}
 	return string(r)
 }