Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated AU regex and added SG regex for is_passport. #23

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

benjaminlhai
Copy link
Contributor

The AU Passport regex has included 2 leading letters in upper case since 2014-15. Although there are still possibilities of finding a single leading digit passport number.

Other services have been updated see: https://learn.microsoft.com/en-us/purview/sit-defn-australia-passport-number
While some have not: https://www.microfocus.com/documentation/idol/IDOL_24_2/EductionGrammars_24.2_Documentation/PII/Content/PII/PII_Examples_Passport.htm

Updated the regex to include both options.

Added tests for negative and positive results.

I also added the SG passport regex and tests for that, reference: https://learn.microsoft.com/en-us/purview/sit-defn-singapore-passport-number

Ran 2 tests in 0.011s

OK
OK - test_invalid_passport_number
OK - test_valid_passport_number

Process finished with exit code 0

@theteladras
Copy link
Owner

Hey @benjaminlhai thanks for noting this and thanks for the contribution! 🎉

@theteladras theteladras merged commit 15dcb04 into theteladras:main Jul 31, 2024
3 checks passed
@benjaminlhai
Copy link
Contributor Author

hey @theteladras, Thanks for this package, I'll be sure to continue contributions. Just to note - publishing seems to be having issues, for now I'm referencing the package via git+xxx://, could you take a look when you have a moment?

@theteladras
Copy link
Owner

hey @theteladras, Thanks for this package, I'll be sure to continue contributions. Just to note - publishing seems to be having issues, for now I'm referencing the package via git+xxx://, could you take a look when you have a moment?

That is awesome to hear!
I will take a look on the mentioned issue ASAP.

@theteladras
Copy link
Owner

@benjaminlhai To let you know that the issue with the package deployment has been resolved, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants