LLEXT: persistent dependency #9804
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyakh
force-pushed
the
depend-persist
branch
6 times, most recently
from
698ac69 to
497d5b7
Compare
|
SOFCI TEST |
|
CI is good now. The latest test re-run was to test a Zephyr logging fix from yesterday, and it does indeed (again) fix logging during module unloading. This testing version of the PR uses MTL to test the new approach to dependencies, so MTL results are most important, but others obviously shouldn't regress either. MTL use of LLEXT including dependencies can be seen in https://sof-ci.01.org/sofpr/PR9804/build10554/devicetest/index.html?model=MTLP_SDW_AIOC&testcase=check-playback-all-formats - the very first test there plays audio to the "Speaker" PCM, whose pipeline contains eq_fir, which uses the FIR library module. QuickBuild failure is expected - it doesn't support loading the "openmodules" library yet. Otherwise the results are: |
Merged
|
Updated the Zephyr PR, let's re-test |
|
SOFCI TEST |
lyakh
force-pushed
the
depend-persist
branch
from
497d5b7 to
6343253
Compare
|
Need to keep last CI results in https://sof-ci.01.org/sofpr/PR9804/build10714/devicetest/index.html before rebasing. |
Add a dedicated type for auxiliary LLEXT objects, not implementing the Module Adapter API. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
The LLEXT context is currently bound to the Module Adapter API which shouldn't be the case because we also need generic LLEXT-based loadable SOF objects. This patch moves the context to struct lib_manager_module which is safe, because the library manager is always needed when dynamically loading modules. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Extract localisation and linking of a single LLEXT module into a separate function, it will be re-used for auxiliary modules. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Currently lib_manager_module_free() first checks, if an LLEXT module is being freed. If so, it first calls llext_unload() and then - if the use-count is reported as zero, calls llext_manager_free_module(). Simplify this process by just calling llext_manager_free_module() and letting it handle llext_unload() internally. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This reverts commit cf31c9c. We do now need to store BSS information for auxiliary LLEXT management. When instantiating such a module for the second time, we don't have access to Zephyr LLEXT information any more, so we need to use our cached information for .bss allocation. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Auxiliary modules, implemented as LLEXT and used to provide functionality for other modules, don't have TOML configuration, make rimage skip that step for them. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
llext_manager_load_module()'s ebl argument is only used for .bss alignment. Calculate it automatically to eliminate ebl, because it isn't available during following loads. e.g. when reloading dependencies. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Currently when module's last instance is destroyed, it's freed and its Zephyr context is destroyed too. At the same time the module is kept in DRAM in a linked and relocated state, which means, that next time when we have to use it, we need to tell Zephyr to instantiate it while skipping the linking step. Additionally this makes handling dependencies inconvenient: they are created during the linking step by Zephyr and therefore are lost when the module is released. Then, as described above, they're not recreated when the linking step is skipped during a subsequent load. To fix this problem this commit avoids destroying module's Zephyr context when freeing. This costs around 200 bytes but makes handling of dependencies possible. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add support for auxiliary modules, exporting symbols to other modules. In such cases Zephyr LLEXT API generates a dependency list, available while the dependent module is loaded. SOF now preserves the minimum module context even while it isn't used, that includes dependency lists, so on a repeated load they're still available. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
FIR support code is used by eq-fir and by tdfb. When both of them are built as LLEXT modules, FIR supporting functions can be dynamically loaded too. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Update Zephyr to fetch commits:
037cb87276bb ("llext: export spinlock debugging symbols to extensions")
a2a587ae20b4 ("llext: fix symbol exporting for ET_REL")
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
force-pushed
the
depend-persist
branch
from
6343253 to
8f6df3d
Compare
|
SOFCI TEST |
lyakh
force-pushed
the
depend-persist
branch
from
8f6df3d to
8a15be7
Compare
This reverts commit dbdfe32 and selects COMP_STUBS to enable building of test stubs. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Now that the Linux driver requirement for LLEXT dependencies has been merged, we can test on any ACE architecture. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
force-pushed
the
depend-persist
branch
from
8a15be7 to
c208dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should replace #9399