smart-amp-test: remove obsolete build options #9773
Merged
+61
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abonislawski whats happening with LMDK these days now that we can do llext ? Can we support LMDK APIs and loading via llext ? |
lyakh
requested review from
RanderWang,
marcinszkudlinski,
pblaszko,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
@lgirdwood we are only keeping one LMDK module (downmixer) in CI just in case if something change in the future roadmap. But in general it is frozen and we can remove smart-amp |
|
CI: https://sof-ci.01.org/sofpr/PR9773/build10155/devicetest/index.html , https://sof-ci.01.org/sofpr/PR9773/build10157/devicetest/index.html and https://sof-ci.01.org/sofpr/PR9773/build10156/devicetest/index.html - all errors are known: missing test devices and a failure in suspend-resume. |
lgirdwood
approved these changes
Jan 14, 2025
kv2019i
reviewed
Jan 15, 2025
| @@ -15,7 +15,7 @@ SECTIONS { | |||
| _data_end = ABSOLUTE(.); | |||
| } >HPSRAM_seg : data_phdr | |||
|
|
|||
| .rodata : ALIGN(4096) { | |||
| .rodata : { | |||
There was a problem hiding this comment.
? Thhis seems very odd in a PR to remove smart-ampt-test
|
@lyakh Can you rebase? |
kv2019i
approved these changes
Feb 13, 2025
smart-amp-test was one of the first modules, used as an example for loadable module development. Currently it can be built in 4 ways: - monolithic - as an LMDK native module - as legacy LLEXT - as current LLEXT This commit removes legacy options and only preserves the first and the last options. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lgirdwood
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smart-amp-test was one of the first modules, used as an example for loadable module development. Currently it can be built in 4 ways:
This commit removes legacy options and only preserves the first and the last possibilities.