Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib: Add to dai-legacy.h struct copier_gain_params for testbench #9536

Merged

Conversation

singalsu
Copy link
Collaborator

@singalsu singalsu commented Oct 2, 2024

Two patches for copier to prevent IPC4 testbench build fail. Copier is part of SOF lib build that is linked to testbench executable. File component is a minimal implementation of a copier and uses copier headers.

The new copier gain feature needs this structure. The added
member is copied directly from dai-zephyr.h. Testbench IPC4
is using legacy DAI definitions instead of Zephyr DAI to avoid
to include a lot of difficult dependencies. Build of testbench
fails if dai-legacy.h does not contain this.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The include of dai-zephyr.h causes IPC4 testbench build to
fail due to further include of Zephyr headers. Since the
copier_generic.c build is not needing it, it can be removed.

The HiFi build version copier_hifi.c is already without
this include.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@kv2019i
Copy link
Collaborator

kv2019i commented Oct 3, 2024

Re-ran a few github CI flows, now looks good. Proceeding with merge.

@kv2019i kv2019i merged commit 77dec14 into thesofproject:main Oct 3, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants