cmake: Improve source hash calculation #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message shoulddn't be in imperative mode, to follow rules. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
This is possible location of .git folder, instead of CMAKE_SOURCE_DIR. Without this patch, checked condition always return false and GIT_LOG_HASH is used instead source code hash. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Temporary files are useful to understand and debug the build. Moving output to another directory, keeps binary directory clean. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Merged
lgirdwood
approved these changes
Aug 27, 2020
ktrzcinx
changed the title
|
@marc-hb good for you ? |
SOF_SRC_HASH always must have integer value, because of usage them to initialize global variable in source code. Variables, which may be empty should be used inside quotation to prevent cmake incorect number of arguments error. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
jajanusz
approved these changes
Aug 31, 2020
|
Jenkins known CI issues on ICL unrelated. |
marc-hb
added
bug
marc-hb
reviewed
Dec 24, 2021
| string(SUBSTRING ${SOF_SRC_HASH_LONG} 0 8 SOF_SRC_HASH) | ||
| message(STATUS "Source content hash: ${SOF_SRC_HASH}") | ||
| else() | ||
| string(SUBSTRING ${GIT_LOG_HASH} 0 8 SOF_SRC_HASH) | ||
| message(WARNING "Source content hash can't be calculated, use GIT_LOG_HASH") | ||
| if("${GIT_LOG_HASH}") |
There was a problem hiding this comment.
This is broken, fix submitted in PR #5129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.git folder should be looked for in SOF_ROOT_SOURCE_DIRECTORY. Moreover addressed @marc-hb suggestions from #3195 (comment)