Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a shell redirection instead of sof-logger's -o option #929

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Jul 12, 2022

As sof-logger must run as root, sudo sof-logger -o ... creates logs/
directories with a mix of user and root content. Use a plain >
redirection instead so all log files are owned by the user running the
script.

Signed-off-by: Marc Herbert marc.herbert@intel.com

As sof-logger must run as root, `sudo sof-logger -o ...` creates logs/
directories with a mix of user and root content. Use a plain >
redirection instead so all log files are owned by the user running the
script.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Jul 12, 2022

Usual suspend/resume failures in https://sof-ci.01.org/softestpr/PR929/build64/devicetest/, everything else green.

@marc-hb marc-hb marked this pull request as ready for review July 12, 2022 03:53
@marc-hb marc-hb requested a review from a team as a code owner July 12, 2022 03:53
@marc-hb marc-hb requested a review from keqiaozhang July 12, 2022 05:10
Copy link

@paulstelian97 paulstelian97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I normally do when manually testing so yea.

@marc-hb marc-hb merged commit ec5579f into thesofproject:main Jul 13, 2022
@marc-hb marc-hb deleted the redirect-sof-logger branch July 13, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants