Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

case-lib: add an option to control fallback behavior #914

Merged
merged 1 commit into from
May 31, 2022

Conversation

aiChaoSONG
Copy link

Previously, if SOF card is not detected from the system,
we will export pipelines from proc file system, this is
good for legacy HDA test, but for SOF test, this causes
false positive because usually under this condition, we
are testing USB sound card or Nvidia HDMI.

This patch adds an option to control the fallback behavior,
It should be set to 'false' for SOF test, and set to 'true'
for legacy HDA test.

Signed-off-by: Chao Song chao.song@linux.intel.com

Previously, if SOF card is not detected from the system,
we will export pipelines from proc file system, this is
good for legacy HDA test, but for SOF test, this causes
false positive because usually under this condition, we
are testing USB sound card or Nvidia HDMI.

This patch adds an option to control the fallback behavior,
It should be set to 'false' for SOF test,  and set to 'true'
for legacy HDA test.

Signed-off-by: Chao Song <chao.song@linux.intel.com>
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer new modes like "TEST_HDA" or "TEST_USB" but it would be much work, this is quick and simple and gets the job done without too much technical debt. Thx for the quick fix!

Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would have a more explicit parameter to e.g. test on USB only or NVIDIA only, but this is good enough for our own tests.

Thanks @aiChaoSONG !

@aiChaoSONG
Copy link
Author

The new env is setup on our two RKL devices, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants