Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-sof-logger: add missing sof-kernel-log-check.sh #912

Merged
merged 1 commit into from
May 26, 2022

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented May 26, 2022

This would have caught kernel crash
https://sof-ci.01.org/linuxpr/PR3645/build166/devicetest/?model=CML_RVP_SDW_ZEPHYR&testcase=check-sof-logger

More details in

This check is especially important considering check-sof-logger unload
and reloads kernel modules.

Signed-off-by: Marc Herbert marc.herbert@intel.com

This would have caught kernel crash
https://sof-ci.01.org/linuxpr/PR3645/build166/devicetest/?model=CML_RVP_SDW_ZEPHYR&testcase=check-sof-logger

This check is especially important considering check-sof-logger unload
and reloads kernel modules.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 26, 2022

SOFCI TEST

@marc-hb marc-hb marked this pull request as ready for review May 26, 2022 04:12
@marc-hb marc-hb requested a review from a team as a code owner May 26, 2022 04:12
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 26, 2022

The TIMEOUT in https://sof-ci.01.org/softestpr/PR912/build39/devicetest/?model=BYT_MB_NOCODEC&testcase=check-ipc-flood was in a different test: unrelated.

Everything else was green.

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 26, 2022

Refreshed #799 also hardens this test and start looking at firmware ERRORs for the first time ever!

Copy link
Contributor

@keqiaozhang keqiaozhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plbossart plbossart merged commit 874f415 into thesofproject:main May 26, 2022
@marc-hb marc-hb deleted the logger-checks-kernel branch May 27, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants