Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite topology tools with Construct to improve the readability and maintainability #755

Merged
merged 5 commits into from
Sep 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
## Environment set up
### requirements
#### apt packages
expect alsa-utils python3 python3-graphviz
expect alsa-utils python3 python3-construct python3-graphviz
```
sudo apt install expect alsa-utils python3 python3-graphviz
sudo apt install expect alsa-utils python3 python3-construct python3-graphviz
```
#### user group
sudo adm audio
Expand Down Expand Up @@ -144,9 +144,12 @@ apl
* sof-tplgreader.py
<br> tplgtool.py wrapper, it reads info from tplgtool.py to analyze topologies.

* tplgtool.py
* tplgtool2.py
<br> Dumps info from tplg binary file.

* tplgtool.py
<br> Dumps info from tplg binary file. (deprecated)


## System configuration tips

Expand Down
1 change: 1 addition & 0 deletions env-check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func_check_pkg aplay
func_check_pkg python3
# jq is command-line json parser
func_check_pkg jq
func_check_python_pkg construct
func_check_python_pkg graphviz
func_check_python_pkg numpy
func_check_python_pkg scipy
Expand Down
2 changes: 2 additions & 0 deletions python-deps.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
python3-numpy
python3-scipy
pylint
python3-graphviz
python3-construct=2.8.*
2 changes: 2 additions & 0 deletions tools/tplgtool.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/usr/bin/env python3

import warnings
import os
import sys
import argparse
Expand Down Expand Up @@ -856,6 +857,7 @@ def find_interweaved_pipeline(self, comp):
return interweaved_dict

if __name__ == "__main__":
warnings.warn("tplgtool.py is deprecated, use tplgtool2.py instead.", DeprecationWarning)

def parse_cmdline():
parser = argparse.ArgumentParser(add_help=True, formatter_class=argparse.RawTextHelpFormatter,
Expand Down
Loading